From f299ef4ef487f6ba33b4c90dba4ea352a929033b Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Sat, 2 May 2026 08:46:33 +1000 Subject: [PATCH] Temporarily disable the Zenodo release job while the current token and record setup is failing in CI, so tagged releases can keep publishing to PyPI and creating GitHub releases without blocking on a broken external integration. Update the release metadata test to match the temporary workflow state while preserving coverage for the active release steps. --- .github/workflows/publish-pypi.yml | 96 ++++++++++++------------ ultraplot/tests/test_release_metadata.py | 10 +-- 2 files changed, 50 insertions(+), 56 deletions(-) diff --git a/.github/workflows/publish-pypi.yml b/.github/workflows/publish-pypi.yml index e5f7144c0..061c920c0 100644 --- a/.github/workflows/publish-pypi.yml +++ b/.github/workflows/publish-pypi.yml @@ -134,51 +134,51 @@ jobs: with: generate_release_notes: true - publish-zenodo: - name: Publish Zenodo release - needs: publish-github-release - runs-on: ubuntu-latest - if: github.event_name == 'push' - permissions: - contents: read - env: - ZENODO_ACCESS_TOKEN: ${{ secrets.ZENODO_ACCESS_TOKEN }} - steps: - - uses: actions/checkout@v6 - with: - fetch-depth: 0 - - - uses: actions/setup-python@v6 - with: - python-version: "3.12" - - - name: Install release tooling - run: | - python -m pip install --upgrade pip - python -m pip install PyYAML - shell: bash - - - name: Download artifacts - uses: actions/download-artifact@v8 - with: - name: dist-${{ github.sha }}-${{ github.run_id }}-${{ github.run_number }} - path: dist - - - name: Generate release citation metadata - run: | - python tools/release/sync_citation.py \ - --tag "${GITHUB_REF_NAME}" \ - --output "${RUNNER_TEMP}/CITATION.cff" - shell: bash - - - name: Check tree stayed clean - run: | - git diff --quiet || (git status --short && git diff && exit 1) - shell: bash - - - name: Publish to Zenodo - run: | - python tools/release/publish_zenodo.py \ - --dist-dir dist \ - --citation-file "${RUNNER_TEMP}/CITATION.cff" - shell: bash + # publish-zenodo: + # name: Publish Zenodo release + # needs: publish-github-release + # runs-on: ubuntu-latest + # if: github.event_name == 'push' + # permissions: + # contents: read + # env: + # ZENODO_ACCESS_TOKEN: ${{ secrets.ZENODO_ACCESS_TOKEN }} + # steps: + # - uses: actions/checkout@v6 + # with: + # fetch-depth: 0 + # + # - uses: actions/setup-python@v6 + # with: + # python-version: "3.12" + # + # - name: Install release tooling + # run: | + # python -m pip install --upgrade pip + # python -m pip install PyYAML + # shell: bash + # + # - name: Download artifacts + # uses: actions/download-artifact@v8 + # with: + # name: dist-${{ github.sha }}-${{ github.run_id }}-${{ github.run_number }} + # path: dist + # + # - name: Generate release citation metadata + # run: | + # python tools/release/sync_citation.py \ + # --tag "${GITHUB_REF_NAME}" \ + # --output "${RUNNER_TEMP}/CITATION.cff" + # shell: bash + # + # - name: Check tree stayed clean + # run: | + # git diff --quiet || (git status --short && git diff && exit 1) + # shell: bash + # + # - name: Publish to Zenodo + # run: | + # python tools/release/publish_zenodo.py \ + # --dist-dir dist \ + # --citation-file "${RUNNER_TEMP}/CITATION.cff" + # shell: bash diff --git a/ultraplot/tests/test_release_metadata.py b/ultraplot/tests/test_release_metadata.py index c6c570242..94c631a29 100644 --- a/ultraplot/tests/test_release_metadata.py +++ b/ultraplot/tests/test_release_metadata.py @@ -131,10 +131,9 @@ def test_readme_citation_section_uses_repository_metadata(): assert "@software{" not in text -def test_publish_workflow_creates_github_release_and_pushes_to_zenodo(): +def test_publish_workflow_creates_github_release(): """ - Release tags should sync citation metadata, create a GitHub release, and - publish the same dist to Zenodo. + Release tags should sync citation metadata and create a GitHub release. """ text = PUBLISH_WORKFLOW.read_text(encoding="utf-8") assert 'tags: ["v*"]' in text @@ -142,8 +141,3 @@ def test_publish_workflow_creates_github_release_and_pushes_to_zenodo(): assert "--tag" in text assert "--output" in text assert "softprops/action-gh-release@v2" in text - assert "publish-zenodo:" in text - assert "ZENODO_ACCESS_TOKEN" in text - assert "tools/release/publish_zenodo.py" in text - assert "--dist-dir dist" in text - assert '--citation-file "${RUNNER_TEMP}/CITATION.cff"' in text