feat(leaderboard): added page indicator (@Repr-dev)#7818
Open
Repr-dev wants to merge 2 commits intomonkeytypegame:masterfrom
Open
feat(leaderboard): added page indicator (@Repr-dev)#7818Repr-dev wants to merge 2 commits intomonkeytypegame:masterfrom
Repr-dev wants to merge 2 commits intomonkeytypegame:masterfrom
Conversation
github-actions
Bot
added
the
waiting for review
Member
|
Maybe something like this instead? |
Miodec
added
the
waiting for update
Member
|
Or we could go with something more classic |
github-actions
Bot
removed
the
waiting for update
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At the moment, it is impossible to tell which page of monkeytype.com/leaderboards you are on just from the content of the webpage. One must look at the URL parameters (/leaderboards?...&page=X) in order to get this information. So, I added a numerical indicator next to the page control buttons.
All this code does is add a span element in the same container as the page control buttons. The span is placed to the left of the buttons and is given a lot of the same Tailwind classes. The page number in the span comes from the data that is already being passed down to the buttons.
Old:
New (replication of my approach, made with Chrome Inspector):
Stems from Discussion #7815. First open source contribution