Make is_revert stricter, to match GCCs changelog scripts#23
Open
ArsenArsen wants to merge 1 commit intoAdaCore:masterfrom
Open
Make is_revert stricter, to match GCCs changelog scripts#23ArsenArsen wants to merge 1 commit intoAdaCore:masterfrom
ArsenArsen wants to merge 1 commit intoAdaCore:masterfrom
Conversation
|
|
ArsenArsen
force-pushed
the
gcc-strict-revert
branch
from
af7e843 to
d868361
Compare
Reverts like https://gcc.gnu.org/cgit/gcc/commit/?id=eec8da328cf1f91db302ab4cee803e269e68ad33 are let through by the hooks, but then lead to failures in the changelog generating script: https://inbox.sourceware.org/gccadmin/20260415001632.71DF64BA23C4@sourceware.org/ This check should prevent that.
ArsenArsen
force-pushed
the
gcc-strict-revert
branch
from
d868361 to
f3a4440
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts like
https://gcc.gnu.org/cgit/gcc/commit/?id=eec8da328cf1f91db302ab4cee803e269e68ad33 are let through by the hooks, but then lead to failures in the changelog generating script:
https://inbox.sourceware.org/gccadmin/20260415001632.71DF64BA23C4@sourceware.org/
This check should prevent that.