zipper: short-circuit on shared subtries#36
Open
marcin-rzeznicki wants to merge 2 commits intozipper_join_nfrom
Open
zipper: short-circuit on shared subtries#36marcin-rzeznicki wants to merge 2 commits intozipper_join_nfrom
marcin-rzeznicki wants to merge 2 commits intozipper_join_nfrom
Conversation
Active child masks were updated before structural sharing check
Owner
|
Since this code is contingent on a criterion that does occur in PathMaps loaded from a set (without merkleize), I'd like to see some tests that specifically exercise this codepath. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance merge logic by detecting structural sharing:
If all active zippers share the same node, delegate to
MergePolicy::on_idand skip the entire subtree.