Skip to content

BinningPolicy: Fix bug in getAllBinsCount#15083

Open
vkucera wants to merge 1 commit intoAliceO2Group:devfrom
vkucera:binning
Open

BinningPolicy: Fix bug in getAllBinsCount#15083
vkucera wants to merge 1 commit intoAliceO2Group:devfrom
vkucera:binning

Conversation

@vkucera
Copy link
Copy Markdown
Collaborator

@vkucera vkucera commented Feb 18, 2026

No description provided.

@vkucera vkucera requested a review from a team as a code owner February 18, 2026 18:19
@github-actions
Copy link
Copy Markdown
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@vkucera vkucera marked this pull request as draft February 24, 2026 14:29
@vkucera vkucera marked this pull request as ready for review February 24, 2026 14:29
@vkucera vkucera requested review from aalkin and ktf February 24, 2026 14:39
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Feb 25, 2026

Error while checking build/O2/fullCI_slc9 for 4a93725 at 2026-04-24 21:11:

## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local10/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 128
[ERROR] Workflow crashed - PID 13413 (internal-dpl-aod-writer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device internal-dpl-aod-writer: pid 13413 (exit 128)
[ERROR] SEVERE: Device internal-dpl-aod-writer (13413) returned with 128


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/629ff3bd838b9b17b7fb37d58f721e501881d020/slc9_x86-64/o2checkcode/1.0-local702/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='O2-customization ninja date CMake json-c Alice-GRID-Utils safe_int defaults-release bz2 googlebenchmark pytorch_cpuinfo double-conversion ninja-fortran MPFR alibuild-recipe-tools UUID FairCMakeModules Python-modules-list'
+ echo 'FULL_BUILD_REQUIRES=O2-customization ninja date CMake json-c Alice-GRID-Utils safe_int defaults-release bz2 googlebenchmark pytorch_cpuinfo double-conversion ninja-fortran MPFR alibuild-recipe-tools UUID FairCMakeModules Python-modules-list'
FULL_BUILD_REQUIRES=O2-customization ninja date CMake json-c Alice-GRID-Utils safe_int defaults-release bz2 googlebenchmark pytorch_cpuinfo double-conversion ninja-fortran MPFR alibuild-recipe-tools UUID FairCMakeModules Python-modules-list
++ env
++ cut -f1 -d=
++ grep -v '^DEFAULT_'
++ grep -v PKGREVISION
++ grep -v ALIBUILD_RECIPE_TOOLS
++ grep REVISION
++ sed -e s/_REVISION//
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 10
+ REVISION_VALUE=10
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
+++ echo /sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ ROOT_PATH_VALUE=/sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ '[' -z 10 ']'
+ echo 'O2-customization ninja date CMake json-c Alice-GRID-Utils safe_int defaults-release bz2 googlebenchmark pytorch_cpuinfo double-conversion ninja-fortran MPFR alibuild-recipe-tools UUID FairCMakeModules Python-modules-list'
+ tr '[:lower:]' '[:upper:]'
[0 more errors; see full log]

Full log here.

@github-actions
Copy link
Copy Markdown
Contributor

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions Bot added the stale label Mar 28, 2026
@vkucera
Copy link
Copy Markdown
Collaborator Author

vkucera commented Mar 30, 2026

@aalkin Ping

@aalkin
Copy link
Copy Markdown
Member

aalkin commented Mar 30, 2026

Sorry @vkucera, but I do not have merging rights. @ktf could you please take a look?

@github-actions github-actions Bot removed the stale label Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants