[O2B-1552] Move ad hoc filters inside runs overviews model to filtering model by NarrowsProjects · Pull Request #2106 · AliceO2Group/Bookkeeping

NarrowsProjects · 2026-03-10T12:51:11Z

I have a JIRA ticket

branch and/or PR name(s) include(s) JIRA ID
issue has "Fix version" assigned
issue "Status" is set to "In review"
PR labels are selected

Notable changes for users:

The monte carlo reproducable as not bad filters from the runs per .... overview pages has been changed to also be cleared when the 'reset all filters' button is pressed to be in line with all other filters.

Notable changes for developers:

Filter restructuring

ddflpFilter, dcsFilter, and epnFilter have been moved to the filteringModel.
detectorsQc[_id][notBadFraction] filters have been moved to a new model: MultiCompositeFilterModel.
gaq[notBadFraction] now uses its own filter model with unique normalization logic: GaqFilterModel.

New filter models

GaqFilterModel
- Dedicated model for gaq[notBadFraction].
- Implements custom normalization logic.
ToggleFilterModel
- Introduced for toggle-based filters.
- mcReproducibleAsNotBad has been converted to use this model.
MultiCompositeFilterModel
- New flexible model:
  - Can be instantiated with filters.
  - Supports adding filters dynamically after instantiation.
- Computes normalized values based on:
  - Insertion keys
  - Normalized child filters

Shared filter behavior

mcReproducibleAsNotBad:
- Converted into a ToggleFilterModel.
- Integrated into both:
  - GaqFilterModel
  - MultiCompositeFilterModel
- Important: both models must use the same instance for correct behavior.

New components

RadioButtonFilter
- Replaces filters associated with the restructured filter models.
ToggleFilter (component + model)
- Introduced alongside ToggleFilterModel.

Renaming

detectorsQc[_id][notBadFraction] → detectorsQcNotBadFraction[_id]
- Reduces nesting within the filterModel.

Implementation note

This approach avoids:
- Creating a custom wrapper around NumericalComparisonFilterModel solely for normalization, or
- Nesting MultiCompositeFilterModel within another MultiCompositeFilterModel to achieve automatic normalization.

Changes made to the database:

N/A

… anything

* Filtering by stableBeamsStart and stableBeamsEnd has been added to LHC Fills overview page * lhcFills endpoint & DTO validation modified and testing added for the aforementioned changes --------- Co-authored-by: GuustMetz <guust.metz@cern.ch> Co-authored-by: Guust <metzguust@gmail.com>

* Replaced the two-query pattern with a single queryBuilder in GetAllEnvironmentsUseCase. The previous approach was redundant following Sequelize performance improvements; furthermore, the original implementation's logic was flawed which resulted in the pagination bug.

…unsOverviewModel-to-filteringModel

…y to only notify when notBadFraction is not empty.

…leFilter

isaachilly · 2026-04-22T06:45:54Z

+    /**
+     * @inheritdoc
+     */
+    get isEmpty() {


I think this could do with at least an explanatory comment as it is quite confusing with the false and true wording of everything.

Taken care of

Could this be made clearer with a different choice of words? I think people could get confused with all the falses and trues.

I have now renamed the parameter to untoggledIsEmpty with the adjustments to the isEmpty getter and it's jsdoc

@graduta Me and Guust aggreed it would be good for you to give your opinion on this specifically. I am not convinced a property like _emptyValue set to True/False from constructor and compare to this in the isEmpty() function is not the more clear solution.

Hi, to me isEmpty refers and extends the selection model. Thus:

false - not selected and so empty

true - selected and thus not empty as it contain a value of 1/true

Guust and others added 30 commits February 20, 2026 10:23

chore: remove redundant model assignment.

722caf7

chore: move all filters denoted as so to a filteringModel

f161cae

Make filterInputModel extend filterModel

9faffaf

rename inputfilter to ParsedInputFilter

247943b

implement authorfilter with ParsedInputFilterModel changes

114285d

re-implement filter

f39f7ae

add tag-filters to the filtering object

df1fea3

replace titleFilter and contentFilter with RawTextFilterModels

96ca85f

make Authorfilter an implementation of RawTextFilterModel

93b3291

add runs filter to the filteringmodel

5a5e830

add environments filter to the filteringmodel

b5e7148

add lhcFills filter to the filteringmodel

3507ba0

add created filter to the filteringmodel

9c63409

move the sort 'filter' to fetchlogs, since it doesn't actually filter…

5500b3e

… anything

change filter to rawTextFilter for title

a09ae8b

fix test by changing event type to 'change'

512999b

fix content and author tests

0f15812

import openFilteringPanel and resetFilters

7b641ca

fix createdAt filter test

5ab8218

change event types to change

4c96d73

fix isAnyFilterActive

18ce4dc

remove _raw as from authorfilterModel, as it serves no purpose

685dd38

chore: removed ParsedInputFilterModel

4e132fd

chore: add toLowerCase to filterQueryParam computation

caf9812

remove the combination operator from runs

3efdf1d

remove the combination operator from envirionments

fc61bea

remove the combination operator from lhcFills

9c4df68

make filter computation much more compact using filteringmodel.normalize

b860320

NarrowsProjects and others added 3 commits April 20, 2026 07:55

Merge branch 'main' into improv/O2B-1552/Move-ad-hoc-filters-inside-r…

aba1d47

…unsOverviewModel-to-filteringModel

feat: change GaqFilterModel.notBadFraction notification functionallit…

4e92c1e

…y to only notify when notBadFraction is not empty.

chore: fix linter problems

4e9559b

isaachilly reviewed Apr 20, 2026

View reviewed changes

Comment thread lib/public/components/Filters/common/filters/ToggleFilterModel.js Outdated

feat: change isToggled to a getter

4e215a4

NarrowsProjects requested a review from isaachilly April 21, 2026 07:13

isaachilly reviewed Apr 21, 2026

View reviewed changes

Comment thread lib/public/components/Filters/common/filters/radioButtonFilter.js Outdated

NarrowsProjects added 3 commits April 21, 2026 13:28

chore: remove the bad filter

c2b3b58

chore: remove spelling mistake in radiobuttonFilter jsdoc

20f79e8

chore: remove spelling mistake in radiobuttonFilter jsdoc

957d4e2

NarrowsProjects requested a review from isaachilly April 21, 2026 11:36

isaachilly reviewed Apr 21, 2026

View reviewed changes

Comment thread lib/domain/dtos/filters/RunFilterDto.js Outdated

isaachilly reviewed Apr 21, 2026

View reviewed changes

Comment thread lib/domain/dtos/filters/RunFilterDto.js Outdated

isaachilly reviewed Apr 21, 2026

View reviewed changes

Comment thread lib/public/components/Filters/common/filters/toggleFilter.js Outdated

NarrowsProjects added 4 commits April 21, 2026 19:06

chore: rename detectorsQcObj to detectorsQcNotBadFractionObj

8dc7d18

chore: fix datapass check in gaq notbadfraction

608b0e7

chore: fix url from test

4920750

return helpers message rather than throwing error

f1b9b26

NarrowsProjects requested a review from isaachilly April 22, 2026 05:05

chore: remove form-group-header class from radiobuttonfilter and togg…

65dc49c

…leFilter

isaachilly reviewed Apr 22, 2026

View reviewed changes

Comment thread lib/domain/dtos/filters/RunFilterDto.js Outdated

NarrowsProjects added 2 commits April 22, 2026 10:53

chore: improve isEmpty comments for toggleFilterModel

38afd8f

chore: use array destructuring to fix eslint issue

6364e5a

NarrowsProjects requested a review from isaachilly April 22, 2026 10:33

NarrowsProjects added 2 commits April 24, 2026 11:13

chore: fix toggleFilter isempty implementation

86eb3b7

feat: update radioFilterModel with defaultIsEmpty argument

8f11704

NarrowsProjects force-pushed the improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel branch from 9f42ad5 to 8f11704 Compare April 24, 2026 09:32

fix eslint errors

660a412

NarrowsProjects force-pushed the improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel branch from 73cf828 to 660a412 Compare April 24, 2026 09:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[O2B-1552] Move ad hoc filters inside runs overviews model to filtering model#2106

[O2B-1552] Move ad hoc filters inside runs overviews model to filtering model#2106
NarrowsProjects wants to merge 100 commits intomainfrom
improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel

NarrowsProjects commented Mar 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isaachilly Apr 22, 2026

Uh oh!

NarrowsProjects Apr 22, 2026

Uh oh!

isaachilly Apr 24, 2026

Uh oh!

NarrowsProjects Apr 24, 2026

Uh oh!

isaachilly Apr 24, 2026

Uh oh!

graduta Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

NarrowsProjects commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I have a JIRA ticket

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isaachilly Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

NarrowsProjects Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

isaachilly Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

NarrowsProjects Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

isaachilly Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

graduta Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

NarrowsProjects commented Mar 10, 2026 •

edited

Loading