[O2B-1556] Configure filtering model observability to set active filters to the url#2142
Conversation
added 13 commits
April 21, 2026 15:31
2292724 to
e012aa9
Compare
…odel-to-extend-FilterModel-or-SelectionModel' into feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url
e012aa9 to
fda9365
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## improv/O2B-1557/Force-all-filters-managed-by-FilteringModel-to-extend-FilterModel-or-SelectionModel #2142 +/- ##
=======================================================================================================================================
- Coverage 46.01% 45.92% -0.09%
=======================================================================================================================================
Files 1036 1037 +1
Lines 17126 17153 +27
Branches 3110 3116 +6
=======================================================================================================================================
- Hits 7881 7878 -3
- Misses 9245 9275 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 9 commits
April 22, 2026 13:36
04ce63d to
cbd335d
Compare
NarrowsProjects
commented
Apr 23, 2026
| module.exports.fillInput = async (page, inputSelector, value, events = ['input']) => { | ||
| await page.waitForSelector(inputSelector); | ||
| await page.evaluate((inputSelector, value, events) => { | ||
| await page.waitForFunction((inputSelector, value, events) => { |
Collaborator
Author
There was a problem hiding this comment.
To the reviewers:
This is a stealth fix for a problem that happens for a couple of tests occasionally:
TypeError: Cannot set properties of null (setting 'value')
at evaluate (evaluate at module.exports.fillInput (test/public/defaults.js:671:16), <anonymous>:2:22)This happens because between waitForSelector and the evaluate the selector ceases to be valid.
The waitForFunction guard is more more robust waitForSelector in this scenario.
As this PR adds tests that make back-to-back use of fillInput I thought it appropriate to add it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: