[PWGHF] Replace UPC Lc THnSparse with TTree by Rrantu · Pull Request #15786 · AliceO2Group/O2Physics

Rrantu · 2026-04-15T12:23:46Z

This PR introduces a transition from THnSparse to TTree in the UPC Lc analysis.
Main changes:

Added UPC Lc columns and tables in utilsUpcHf.h
Implemented production and filling of TTree in taskLc.cxx
Removed UPC-related axes from the THnSparse

github-actions · 2026-04-15T12:24:05Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

vkucera · 2026-04-15T12:56:16Z

@Rrantu Columns and tables are parts of the data model. They don't belong in the utility headers.

Rrantu · 2026-04-15T13:09:30Z

Hi @vkucera, thanks for the comment, where would you recommend moving the columns and tables to? Would it be acceptable to define them directly in the task?

vkucera · 2026-04-15T13:29:29Z

Hi @vkucera, thanks for the comment, where would you recommend moving the columns and tables to? Would it be acceptable to define them directly in the task?

Yes, if the tables are not used anywhere else, please put them in the task.

lubynets · 2026-04-15T15:42:44Z

Dear @Rrantu, @vkucera, all codeowners, sorry for interfering,
Are Tasks, and not TableProducers, supposed to produce trees? https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/theo2physicsrepo.html#folder-structure

vkucera · 2026-04-15T15:47:57Z

Dear @Rrantu, @vkucera, all codeowners, sorry for interfering, Are Tasks, and not TableProducers, supposed to produce trees? https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/theo2physicsrepo.html#folder-structure

No, they are not.

Rrantu · 2026-04-15T16:25:35Z

Hi @lubynets, Thanks for the question. In this case, the tables are only used within this task, and the trees are produced specifically for this analysis. Also, there are other tasks that produce trees in a similar way.

Rrantu · 2026-04-17T13:59:52Z

Hi @vkucera, could you please take a look at my updated code?

Rrantu · 2026-04-20T13:29:28Z

Hi @vkucera, when you have time, could you please take a look at my updated? Thanks!

vkucera · 2026-04-23T11:05:08Z

                if (gap == o2::aod::sgselector::TrueGap::SingleGapA || gap == o2::aod::sgselector::TrueGap::SingleGapC) {
-                  std::vector<double> valuesToFill{massLc, pt, outputBkg, outputPrompt, outputFD, static_cast<double>(numPvContributors), static_cast<double>(fitInfo.ampFV0A), static_cast<double>(fitInfo.ampFT0A), static_cast<double>(fitInfo.ampFT0C), static_cast<double>(zdcEnergyZNA), static_cast<double>(zdcEnergyZNC), static_cast<double>(zdcTimeZNA), static_cast<double>(zdcTimeZNC)};
-                  registry.get<THnSparse>(HIST("hnLcUpcVarsWithBdt"))->Fill(valuesToFill.data());
+                  rowCandUpcBdt(massLc, pt, outputBkg, outputPrompt, outputFD, static_cast<float>(fitInfo.ampFV0A), static_cast<float>(fitInfo.ampFT0A), static_cast<float>(fitInfo.ampFT0C), static_cast<float>(zdcTimeZNA), static_cast<float>(zdcTimeZNC));


What types are the values before casting?

O2Physics/PWGUD/Core/UDHelpers.h

Line 300 in a839c00

float FV0AmplitudeA(TFV0 fv0)

Before casting the values are of type float.

So why do you cast them to the same type?

gluparel · 2026-04-23T13:42:33Z

Dear @Rrantu, @vkucera, all codeowners, sorry for interfering, Are Tasks, and not TableProducers, supposed to produce trees? https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/theo2physicsrepo.html#folder-structure

No, they are not.

Hi @vkucera, actually I am in favour of what suggested by @lubynets and I would avoid to add trees here and I would suggest to use the Lc TreeCreator: https://github.com/AliceO2Group/O2Physics/blob/master/PWGHF/TableProducer/treeCreatorLcToPKPi.cxx

Grazia

alibuild · 2026-04-23T16:06:48Z

Error while checking build/O2Physics/o2 for 44d3060 at 2026-04-23 18:06:

No log files found

Full log here.

vkucera · 2026-04-23T16:20:26Z

Dear @Rrantu, @vkucera, all codeowners, sorry for interfering, Are Tasks, and not TableProducers, supposed to produce trees? https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/theo2physicsrepo.html#folder-structure

No, they are not.

Hi @vkucera, actually I am in favour of what suggested by @lubynets and I would avoid to add trees here and I would suggest to use the Lc TreeCreator: https://github.com/AliceO2Group/O2Physics/blob/master/PWGHF/TableProducer/treeCreatorLcToPKPi.cxx

Grazia

Hi @gluparel , what are your reasons in favour of that?
My main reason against is that the logic of selecting candidates and filling them in the trees in the task is quite complicated and very different from the way the tree creator output is filled. Adding the same logic in the tree creator for one specific analysis does not seem justified to me and it would cause code duplication which would bring further maintenance work.

zhangbiao-phy · 2026-04-23T16:35:58Z

Dear @Rrantu, @vkucera, all codeowners, sorry for interfering, Are Tasks, and not TableProducers, supposed to produce trees? https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/theo2physicsrepo.html#folder-structure

No, they are not.

Hi @vkucera, actually I am in favour of what suggested by @lubynets and I would avoid to add trees here and I would suggest to use the Lc TreeCreator: https://github.com/AliceO2Group/O2Physics/blob/master/PWGHF/TableProducer/treeCreatorLcToPKPi.cxx
Grazia

Hi @gluparel , what are your reasons in favour of that? My main reason against is that the logic of selecting candidates and filling them in the trees in the task is quite complicated and very different from the way the tree creator output is filled. Adding the same logic in the tree creator for one specific analysis does not seem justified to me and it would cause code duplication which would bring further maintenance work.

Hi @vkucera @gluparel @lubynets, I agree with Vít’s comments here. Regarding adding a tree to the Lc task, I also understand the concerns raised by Grazia and Oleksii. To avoid making things more complicated, I would suggest that @Rrantu create a new dedicated task in the D2H folder (e.g. taskLcUPC.cxx, or more generally taskCharmUPC.cxx). We could also consider using such a task for all HF UPC analyses (different process function for different particle). This would be more appropriate since the event selection and logic are quite different from the standard Lc or other HF task. what do you think?

gluparel · 2026-04-24T07:51:09Z

Dear @Rrantu, @vkucera, all codeowners, sorry for interfering, Are Tasks, and not TableProducers, supposed to produce trees? https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/theo2physicsrepo.html#folder-structure

No, they are not.

Hi @vkucera, actually I am in favour of what suggested by @lubynets and I would avoid to add trees here and I would suggest to use the Lc TreeCreator: https://github.com/AliceO2Group/O2Physics/blob/master/PWGHF/TableProducer/treeCreatorLcToPKPi.cxx
Grazia

Hi @gluparel , what are your reasons in favour of that? My main reason against is that the logic of selecting candidates and filling them in the trees in the task is quite complicated and very different from the way the tree creator output is filled. Adding the same logic in the tree creator for one specific analysis does not seem justified to me and it would cause code duplication which would bring further maintenance work.

Hi @vkucera @gluparel @lubynets, I agree with Vít’s comments here. Regarding adding a tree to the Lc task, I also understand the concerns raised by Grazia and Oleksii. To avoid making things more complicated, I would suggest that @Rrantu create a new dedicated task in the D2H folder (e.g. taskLcUPC.cxx, or more generally taskCharmUPC.cxx). We could also consider using such a task for all HF UPC analyses (different process function for different particle). This would be more appropriate since the event selection and logic are quite different from the standard Lc or other HF task. what do you think?

Hello @zhangbiao-phy , @vkucera , my point is that this task is used by various analyses and we would start to add various trees for the various analyses which need different information. Is this the direction we would like to take? Another option is to have a dedicated task for HF UPC analysis as indeed suggested by Biao and this could be indeed a good option for me, since the various UPC analysis use the same event selections but just a different particle creator.

vkucera · 2026-04-24T09:50:03Z

Hi @gluparel @zhangbiao-phy , thanks for your feedback. I like the idea of a common workflow for UPC analyses if a majority of the code can be shared by multiple species. And if the primary output is expected to have many dimensions, it would indeed be worth making it as a tree creator, as @lubynets pointed out.

Rrantu · 2026-04-24T11:29:54Z

Hi @gluparel @zhangbiao-phy , thanks for your feedback. I like the idea of a common workflow for UPC analyses if a majority of the code can be shared by multiple species. And if the primary output is expected to have many dimensions, it would indeed be worth making it as a tree creator, as @lubynets pointed out.

Thanks for the suggestion. I will try to separate the UPC part into a new task file

vkucera · 2026-04-24T11:37:50Z

Hi @gluparel @zhangbiao-phy , thanks for your feedback. I like the idea of a common workflow for UPC analyses if a majority of the code can be shared by multiple species. And if the primary output is expected to have many dimensions, it would indeed be worth making it as a tree creator, as @lubynets pointed out.

Thanks for the suggestion. I will try to separate the UPC part into a new task file

Thanks @Rrantu , feel free to mark the PR as ready for review when you push the updates. Please do not create a new PR. Just updated this one.

Rrantu added 2 commits April 14, 2026 18:13

replace THnSparse with TTree

dbf77fb

fix format

49e7fa0

Rrantu requested review from NicoleBastid, alibuild, apalasciano, deepathoms, fcatalan92, fcolamar, fgrosa, gluparel, hahassan7, jpxrk, mfaggin, mmazzilli, singhra1994, stefanopolitano, vkucera and zhangbiao-phy as code owners April 15, 2026 12:23

github-actions Bot added the pwghf PWG-HF label Apr 15, 2026

github-actions Bot changed the title ~~Replace UPC Lc THnSparse with TTree~~ [PWGHF] Replace UPC Lc THnSparse with TTree Apr 15, 2026

alibuild mentioned this pull request Apr 15, 2026

Please consider the following formatting changes to #15786 Rrantu/O2Physics#3

Closed

Rrantu added 2 commits April 15, 2026 14:31

fix format issue

4a06d14

fix clang format

ad50d9a

vkucera marked this pull request as draft April 15, 2026 12:54

Move column definitions to the task

2b5d841

Rrantu marked this pull request as ready for review April 15, 2026 14:03

rename Configurable

e3210c9

split into smaller TTrees

4b14cdd

vkucera reviewed Apr 17, 2026

View reviewed changes

Comment thread PWGHF/D2H/Tasks/taskLc.cxx Outdated

rename Configurable

30edf20

Rrantu requested a review from vkucera April 20, 2026 08:01

vkucera marked this pull request as draft April 20, 2026 08:08

Added some document comments

b25898f

Rrantu marked this pull request as ready for review April 20, 2026 08:28

vkucera reviewed Apr 22, 2026

View reviewed changes

Comment thread PWGHF/D2H/Tasks/taskLc.cxx Outdated

Rrantu added 2 commits April 23, 2026 09:30

Added documentation comments

48515fd

remove the redundant comment lines

9b682b8

vkucera reviewed Apr 23, 2026

View reviewed changes

Comment thread PWGHF/D2H/Tasks/taskLc.cxx Outdated

remove documentation comments

44d3060

Rrantu requested a review from vkucera April 23, 2026 11:04

vkucera reviewed Apr 23, 2026

View reviewed changes

Rrantu requested a review from vkucera April 23, 2026 12:13

vkucera marked this pull request as draft April 24, 2026 11:37

Conversation

Rrantu commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Apr 15, 2026

Uh oh!

Rrantu commented Apr 15, 2026

Uh oh!

vkucera commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lubynets commented Apr 15, 2026

Uh oh!

vkucera commented Apr 15, 2026

Uh oh!

Rrantu commented Apr 15, 2026

Uh oh!

Rrantu commented Apr 17, 2026

Uh oh!

Uh oh!

Rrantu commented Apr 20, 2026

Uh oh!

Uh oh!

Uh oh!

vkucera Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Rrantu Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

vkucera Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gluparel commented Apr 23, 2026

Uh oh!

alibuild commented Apr 23, 2026

Uh oh!

vkucera commented Apr 23, 2026

Uh oh!

zhangbiao-phy commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gluparel commented Apr 24, 2026

Uh oh!

vkucera commented Apr 24, 2026

Uh oh!

Rrantu commented Apr 24, 2026

Uh oh!

vkucera commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

github-actions Bot commented Apr 15, 2026 •

edited

Loading

vkucera commented Apr 15, 2026 •

edited

Loading

zhangbiao-phy commented Apr 23, 2026 •

edited

Loading