fix: prevent vertical scroll on mobile keyboard accessory bar#72
Open
TeigenZhang wants to merge 1 commit intoArk0N:masterfrom
Open
fix: prevent vertical scroll on mobile keyboard accessory bar#72TeigenZhang wants to merge 1 commit intoArk0N:masterfrom
TeigenZhang wants to merge 1 commit intoArk0N:masterfrom
Conversation
Add overflow-y: hidden to both .keyboard-accessory-bar declarations so the bar only scrolls horizontally on iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On mobile devices, the accessory bar above the soft keyboard could bounce vertically when the user dragged on it, pulling the whole viewport out of place when the keyboard was open. Fix: disable
touch-actionvertical pan on the bar so horizontal scrolling still works for overflowing buttons but vertical gestures are absorbed by the terminal below.Test plan