feat(response-viewer): ASCII diagram wrap toggle, mobile code blocks, chrome-stripping fallback#75
Open
TeigenZhang wants to merge 7 commits intoArk0N:masterfrom
Open
Conversation
added 7 commits
April 24, 2026 09:50
…ripping in response viewer fallback Session constructor seeded _claudeSessionId with Codeman's session.id as a placeholder, and the message-driven update was gated on !_claudeSessionId — meaning Claude CLI's actual session UUID was never adopted. This broke /api/sessions/:id/last-response JSONL lookups, silently falling through to the terminal-buffer path whose ANSI regex missed \x1b[>c / \x1b[>q queries. - session.ts: update _claudeSessionId whenever a message's session_id differs from current (covers placeholder and stale-resume cases) - app.js: extract _cleanTerminalBuffer with proper CSI regex (param bytes 0x30-0x3F now covers > ? < =) plus a chrome filter for status bar, progress bar, spinner, shell prompt, and hint lines
The response viewer button was mobile-only via a display:none default with a mobile.css override. Flip the default to inline-flex and drop the override so the eye icon appears in the header on every form factor — desktop users get the same quick "Last Response" pane as mobile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seven small commits that polish the Response Viewer (merged in #62) for daily use on mobile and desktop:
<pre>scroll container so it stays pinned to the visual right edge even while scrolling horizontally.─-╿) and block elements (▀-▟) trigger the diagram toggle. Previously arrows and geometric shapes in prose caused false positives.All changes are additive to
_renderMarkdown/_cleanTerminalBuffer/_preprocessAsciiArtinapp.jsplus scoped CSS under.rv-*instyles.css._sanitizeHtml(introduced in master) is still applied to markdown output.Test plan
npm run typecheck/npm run lint/npm run buildpass