Skip to content

Fix incorrect setup for install of python environments. #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tom-Kingstone wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix incorrect setup for install of python environments. #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Python_Engine/Compute/Remove.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public static partial class Compute
[Input("kernelName", "The name of the kernel to remove.")]
public static void RemoveKernel(string kernelName)
{
string kernelPath = Path.Combine(Query.DirectoryKernels(), kernelName);
string kernelPath = Path.Combine(Query.DirectoryKernels(), kernelName.ToLower());
if (Directory.Exists(kernelPath))
Directory.Delete(kernelPath, true);
}
Expand Down
2 changes: 1 addition & 1 deletion Python_Engine/Compute/VirtualEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public static PythonEnvironment VirtualEnvironment(this PythonVersion version, s
}
};

process.StartInfo.Environment["PYTHONHOME"] = "";
process2.StartInfo.Environment["PYTHONHOME"] = "";

using (Process p = Process.Start(process2.StartInfo))
{
Expand Down
2 changes: 1 addition & 1 deletion Python_Engine/Query/VirtualEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public static bool VirtualEnvironmentExists(string envName, PythonVersion python
[Output("kernelDirectory", "The path to the kernel directory.")]
public static string VirtualEnvironmentKernel(string envName)
{
return Path.Combine(Query.DirectoryKernels(), envName);
return Path.Combine(Query.DirectoryKernels(), envName.ToLower());
}

[Description("Get the path to the named BHoM Python virtual environment executable.")]
Expand Down