feat(passkey-crypto): extend package with PRF helpers and sdk-core passkey module#8663
Open
feat(passkey-crypto): extend package with PRF helpers and sdk-core passkey module#8663
Conversation
derranW26
changed the base branch from
WCN-186/passkey-crypto-package
to
master
derranW26
force-pushed
the
WCN-187-passkey-types-v2
branch
13 times, most recently
from
33b1c92 to
587488a
Compare
…sskey module - add buildEvalByCredential and matchDeviceByCredentialId to @bitgo/passkey-crypto - use WebauthnDevice from @bitgo/public-types to avoid circular deps - create sdk-core/passkey/ with WebAuthnProvider, PasskeyAuthResult, PasskeyGetOptions - re-export WebAuthnOtpDevice from @bitgo/public-types in sdk-core - alias KeychainWebauthnDevice to WebauthnDevice from @bitgo/public-types - bump @bitgo/public-types to 6.1.0 and add @bitgo/passkey-crypto to sdk-core TICKET: WCN-187
derranW26
force-pushed
the
WCN-187-passkey-types-v2
branch
2 times, most recently
from
587488a to
20d0e8b
Compare
derranW26
requested review from
alextse-bg,
lokesh-bitgo and
mohammadalfaiyazbitgo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildEvalByCredentialandmatchDeviceByCredentialIdto@bitgo/passkey-crypto, usingWebauthnDevicefrom@bitgo/public-typesto avoid circular dependenciesmodules/sdk-core/src/bitgo/passkey/withWebAuthnProvider,PasskeyAuthResult, andPasskeyGetOptionsinterfacesWebAuthnOtpDevicefrom@bitgo/public-typesin sdk-coreKeychainWebauthnDevicetoWebauthnDevicefrom@bitgo/public-types(removes local duplicate definition)@bitgo/public-typesto6.1.0and adds@bitgo/passkey-cryptoto sdk-core dependenciesDepends on: #8610 (WCN-186 —
@bitgo/passkey-cryptopackage)Blocks: Tickets 3–7
TICKET: WCN-187