feat(sdk-core): add explicit recipient mode typing for TSS signTxRequest#8667
Open
mmcshinsky-bitgo wants to merge 1 commit intomasterfrom
Open
feat(sdk-core): add explicit recipient mode typing for TSS signTxRequest#8667mmcshinsky-bitgo wants to merge 1 commit intomasterfrom
mmcshinsky-bitgo wants to merge 1 commit intomasterfrom
Conversation
mmcshinsky-bitgo
changed the title
mmcshinsky-bitgo
force-pushed
the
feat/tss-sign-tx-recipient-source-types
branch
5 times, most recently
from
063b097 to
b8924a8
Compare
mmcshinsky-bitgo
changed the title
Introduce TssTxRecipientSource and TssSignTxRequestParams so callers can opt into compile-time enforcement of non-empty txParams.recipients via recipientSource Explicit. Default resolved behavior matches existing optional txParams. ECDSA signing validates Explicit at runtime for non-TS callers. ITssUtils.signTxRequest uses the new param type. Add MPCv2 unit test for Explicit. BREAKING CHANGE: ITssUtils.signTxRequest is now typed as TssSignTxRequestParamsWithPrv instead of a minimal inline shape. TypeScript consumers that implement or narrow this interface may need signature updates; runtime behavior for existing callers is unchanged. Refs: WAL-375 #8462 WAL-375
mmcshinsky-bitgo
changed the title
mmcshinsky-bitgo
force-pushed
the
feat/tss-sign-tx-recipient-source-types
branch
from
b8924a8 to
4cec3f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional explicit recipient typing for TSS
signTxRequest(TssTxRecipientSource,TssSignTxRequestParams) so callers can require non-emptytxParams.recipientsat compile time. Default signing behavior is unchanged. ECDSA validates the explicit branch at runtime for non-TypeScript callers. Adds an MPCv2 unit test.Breaking change (TypeScript only):
ITssUtils.signTxRequestis now typed asTssSignTxRequestParamsWithPrvinstead of a minimal inline shape; third-party implementers may need signature updates. Runtime behavior for existing call sites is unchanged.Ticket: WAL-375
Higher bump line: bitgo-ui#10975 — feat: bump SDK packages for MPCv2 transaction verification fix (WCN-151). Keep
@bitgo*/@bitgo-beta*versions at or above that PR across repos before merging.Testing
package.json/ lockfiles match or exceed bitgo-ui#10975 (WCN-151); do not merge a lower SDK bump ahead of that line@bitgo/wasm-mps/web/ related webpack resolution)