fix(abstract-utxo): guard undefined address in preprocessBuildParams#8668
Merged
mohammadalfaiyazbitgo merged 1 commit intomasterfrom Apr 30, 2026
Merged
Conversation
mohammadalfaiyazbitgo
changed the title
…AL-375] What changed: - guard against undefined address in preprocessBuildParams before calling fromExtendedAddressFormat, passing OP_RETURN recipients through unchanged - add unit test for preprocessBuildParams with mixed normal + OP_RETURN recipients - add WCN-323 repro script to examples/ts/btc/wcn323Repro.ts Why: Recipients with no address field (e.g. OP_RETURN outputs using { script, amount }) caused a TypeError crash in preprocessBuildParams when fromExtendedAddressFormat called isScriptRecipient(undefined) -> undefined.toLowerCase(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> TICKET: WAL-375
mohammadalfaiyazbitgo
force-pushed
the
revert-8539-fix/WAL-375-recipients-guard-v2
branch
from
079911c to
9651f36
Compare
davidkaplanbitgo
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
undefinedaddress inpreprocessBuildParamsbefore callingfromExtendedAddressFormat, passing OP_RETURN recipients ({ script, amount }) through unchangedpreprocessBuildParamswith a mixed normal + OP_RETURN recipients arrayRoot Cause
When a recipient has no
addressfield (e.g. an OP_RETURN output using{ script, amount }), destructuring inpreprocessBuildParamsgivesaddress = undefined. CallingfromExtendedAddressFormat(undefined)→isScriptRecipient(undefined)→undefined.toLowerCase()→ TypeError crash.The
checkRecipientpath already had anaddress &&guard (PR #8649), butpreprocessBuildParamswas missed.Test Plan
yarn unit-test --scope @bitgo/abstract-utxopasses including the newpreprocessBuildParamstestwcn323Repro.ts) runs to completion withoutTypeError: Cannot read properties of undefined (reading 'toLowerCase')— confirmed against test env, pending approval created successfullyTicket
WAL-375