chore: update Node.js version to 22 across configuration files#981
chore: update Node.js version to 22 across configuration files#981gliptak wants to merge 1 commit intoFission-AI:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughNode.js runtime version updated from 20 to 22 across the development environment, CI workflows, and package configuration files. All version constraints and base images are synchronized to the new requirement without functional code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
63-63: Optional: centralize Node version to reduce drift risk.You can define one workflow-level env (for example
NODE_VERSION: '22') and reference it in each setup-node step to avoid future partial updates.Also applies to: 119-119, 158-158, 262-262
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci.yml at line 63, Centralize the Node version by adding a workflow-level env like NODE_VERSION: '22' and update each setup-node step to use that env value instead of hardcoding node-version: '22' (replace occurrences of the node-version field in the setup-node actions with the env reference ${{ env.NODE_VERSION }}); update all instances including the current one and the additional occurrences noted (lines referenced in the comment) so all setup-node steps consistently pull from NODE_VERSION.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/ci.yml:
- Line 63: Centralize the Node version by adding a workflow-level env like
NODE_VERSION: '22' and update each setup-node step to use that env value instead
of hardcoding node-version: '22' (replace occurrences of the node-version field
in the setup-node actions with the env reference ${{ env.NODE_VERSION }});
update all instances including the current one and the additional occurrences
noted (lines referenced in the comment) so all setup-node steps consistently
pull from NODE_VERSION.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6fec0fec-8b46-4553-829b-3c0217a90764
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
.devcontainer/devcontainer.json.github/workflows/ci.ymlopenspec/config.yamlpackage.json
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
|
@TabishB please approve workflow runs |
Node 20 going EOL https://nodejs.org/en/about/previous-releases
Summary by CodeRabbit