Skip to content

Target-aware Deep Review reviewer scheduling#559

Draft
limityan wants to merge 14 commits intoGCWing:mainfrom
limityan:yanzhn/deepreview
Draft

Target-aware Deep Review reviewer scheduling#559
limityan wants to merge 14 commits intoGCWing:mainfrom
limityan:yanzhn/deepreview

Conversation

@limityan
Copy link
Copy Markdown
Collaborator

Summary

  • Add target-aware Deep Review manifest construction, including frontend/domain classification, explicit /DeepReview target parsing, and git commit/range changed-file resolution.
  • Persist the Deep Review run manifest through Flow Chat session metadata so continuation and child sessions keep the original reviewer scope.
  • Enforce the persisted manifest in the backend Task pipeline so only active reviewers from the run manifest can be launched.
  • Add custom review subagent tooling validation: require GetFileDiff + Read, share the tooling contract between UI and Review Team execution, and surface invalid reviewers as invalid_tooling skipped reviewers instead of silently dropping them.
  • Add token-budget aware extra reviewer handling and skipped-reviewer reporting for disabled, unavailable, not-applicable, budget-limited, and invalid-tooling cases.

Verification

  • pnpm --dir src/web-ui exec vitest run src/shared/services/reviewTeamService.test.ts src/app/scenes/agents/components/subagentEditorUtils.test.ts
  • pnpm run type-check:web
  • pnpm run lint:web
  • pnpm --dir src/web-ui run test:run
  • cargo test -p bitfun-core deep_review -- --nocapture
  • git diff --check HEAD~4..HEAD

@limityan limityan force-pushed the yanzhn/deepreview branch 3 times, most recently from 273097a to 9ebb682 Compare April 28, 2026 12:11
@limityan limityan force-pushed the yanzhn/deepreview branch 2 times, most recently from afef859 to 944ff21 Compare April 29, 2026 04:13
limityan added 12 commits April 29, 2026 12:22
…S variables

Extract shared icon size and text styling into CSS variables in
_tool-card-common.scss so that dense-command variants (Terminal,
Git) only override spacing, not sizing. This aligns Skill and
Terminal tool cards on icon size (16px), font size (14px),
line-height (1.65), and font-weight (500).

- Add --tool-card-icon-size, --tool-card-action-font-size,
  --tool-card-action-line-height, --tool-card-action-font-weight
- Use variables for SVG width/height and compact-card text
- Remove size/font overrides from .compact-tool-card-wrapper--dense-command

Generated with BitFun

Co-Authored-By: BitFun
…le subcommand

When the AI model mistakenly includes the subcommand name in the
`args` field (e.g. `operation:
- Set overflow: hidden on .explore-region__content by default
- Move overflow-y: auto behind .explore-region--has-scroll class
- Preserve auto-scroll behavior during streaming

Generated with BitFun

Co-Authored-By: BitFun
- Add summary rendering in WebSearchCard when results are empty
- Add i18n keys for summary availability in en-US, zh-CN, zh-TW
- Refactor expandable logic to include summary-only state
@limityan limityan force-pushed the yanzhn/deepreview branch from 944ff21 to a386307 Compare April 29, 2026 08:22
@limityan limityan marked this pull request as draft April 29, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant