You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The approach is wrong: silent skipping is not an option. From CONTRIBUTING.md:
Fail loudly. Avoid constructs that could suppress error messages [...]. This makes debugging and troubleshooting a lot easier.
A silent when makes the run look successful (ok=2 skipped=2), and an admin will not notice that glances was never installed on the RHEL 10 hosts. It also breaks the pattern used for the other RHEL 10 adaptations in this release: redis was reworked to install valkey, mariadb_server got an SELinux workaround, openvpn_server switched its SELinux type. The role keeps doing what it promises, adapted to the platform.
Please switch to a pip-based install on RHEL 10, which the current README already names as the manual workaround:
Use the python_venv role to create a venv (e.g. /opt/glances).
pip install glances into that venv.
Make etc/profile.d/glances.sh.j2 point at the venv binary on RHEL 10, at the packaged binary elsewhere.
Drop the when skip from tasks/main.yml.
Other issues
PR title typo: fix(roles/galnces): skip for rhel10 -> fix(roles/glances): add rhel10 support via pip.
CHANGELOG.md Unreleased entry missing. I would add under ### Fixed:
* **role:glances**: Add RHEL 10 / Rocky 10 / Alma 10 support by installing glances into a Python venv via pip, since the package is not available in EPEL 10.
Drop the now-obsolete sentence Note in the Mandatory Requirements section that the role currently fails on RHEL 10 / Rocky 10 / Alma 10 because glances is not packaged in EPEL 10. from the existing role:glances entry under ### Changed, and revise the COMPATIBILITY note from glances stays at (x) because the package is missing in EPEL 10 (see the role README). to reflect that RHEL 10 is now x.
README indent in Mandatory Requirements: top-level bullets are not indented in LFOps READMEs (see roles/example/README.md and every other role). Replace
* On RHEL-compatible systems, the EPEL repository ...
* On Rocky Linux 9, the CRB repository ...
* On Rocky Linux 10 glances is not available in the EPEL repository for now
with
* On RHEL-compatible systems, the EPEL repository ...
* On Rocky Linux 9, the CRB repository ...
The third bullet becomes obsolete with the pip-based install.
Platform Support section: replace
`glances` is currently not packaged in EPEL 10. On RHEL 10 and clones (Rocky / Alma 10) the role automatically skips all tasks. Install glances manually on those hosts (e.g. via `pip install glances` in a venv, or from a third-party repo) if needed.
with something like
`glances` is not packaged in EPEL 10. On RHEL 10 and clones (Rocky / Alma 10) the role installs glances into a dedicated Python venv at `/opt/glances` via pip; on all other supported platforms glances is installed from the distribution package.
COMPATIBILITY.md: change the glances row from
| glances | (x) | (x) | x | x | (x) | (x) | (x) | (x) | |
to
| glances | (x) | (x) | x | x | x | (x) | (x) | (x) | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.