Skip to content

fix(roles/galnces): skip for rhel10#240

Open
jihan-lf wants to merge 1 commit intomainfrom
fix/rhel10-glances
Open

fix(roles/galnces): skip for rhel10#240
jihan-lf wants to merge 1 commit intomainfrom
fix/rhel10-glances

Conversation

@jihan-lf
Copy link
Copy Markdown
Contributor

No description provided.

@jihan-lf jihan-lf force-pushed the fix/rhel10-glances branch from 48155d4 to dbb0f7c Compare April 30, 2026 07:38
@markuslf
Copy link
Copy Markdown
Member

A few points before this is mergeable.

The approach is wrong: silent skipping is not an option. From CONTRIBUTING.md:

Fail loudly. Avoid constructs that could suppress error messages [...]. This makes debugging and troubleshooting a lot easier.

A silent when makes the run look successful (ok=2 skipped=2), and an admin will not notice that glances was never installed on the RHEL 10 hosts. It also breaks the pattern used for the other RHEL 10 adaptations in this release: redis was reworked to install valkey, mariadb_server got an SELinux workaround, openvpn_server switched its SELinux type. The role keeps doing what it promises, adapted to the platform.

Please switch to a pip-based install on RHEL 10, which the current README already names as the manual workaround:

  1. Use the python_venv role to create a venv (e.g. /opt/glances).
  2. pip install glances into that venv.
  3. Make etc/profile.d/glances.sh.j2 point at the venv binary on RHEL 10, at the packaged binary elsewhere.
  4. Drop the when skip from tasks/main.yml.

Other issues

  • PR title typo: fix(roles/galnces): skip for rhel10 -> fix(roles/glances): add rhel10 support via pip.

  • CHANGELOG.md Unreleased entry missing. I would add under ### Fixed:

    * **role:glances**: Add RHEL 10 / Rocky 10 / Alma 10 support by installing glances into a Python venv via pip, since the package is not available in EPEL 10.
    

    Drop the now-obsolete sentence Note in the Mandatory Requirements section that the role currently fails on RHEL 10 / Rocky 10 / Alma 10 because glances is not packaged in EPEL 10. from the existing role:glances entry under ### Changed, and revise the COMPATIBILITY note from glances stays at (x) because the package is missing in EPEL 10 (see the role README). to reflect that RHEL 10 is now x.

  • README indent in Mandatory Requirements: top-level bullets are not indented in LFOps READMEs (see roles/example/README.md and every other role). Replace

        * On RHEL-compatible systems, the EPEL repository ...
        * On Rocky Linux 9, the CRB repository ...
        * On Rocky Linux 10 glances is not available in the EPEL repository for now
    

    with

    * On RHEL-compatible systems, the EPEL repository ...
    * On Rocky Linux 9, the CRB repository ...
    

    The third bullet becomes obsolete with the pip-based install.

  • Platform Support section: replace

    `glances` is currently not packaged in EPEL 10. On RHEL 10 and clones (Rocky / Alma 10) the role automatically skips all tasks. Install glances manually on those hosts (e.g. via `pip install glances` in a venv, or from a third-party repo) if needed.

    with something like

    `glances` is not packaged in EPEL 10. On RHEL 10 and clones (Rocky / Alma 10) the role installs glances into a dedicated Python venv at `/opt/glances` via pip; on all other supported platforms glances is installed from the distribution package.

  • COMPATIBILITY.md: change the glances row from

    | glances                               |  (x)   |  (x)   |   x    |   x    |   (x)   |    (x)    |    (x)    |    (x)    |                                              |
    

    to

    | glances                               |  (x)   |  (x)   |   x    |   x    |    x    |    (x)    |    (x)    |    (x)    |                                              |
    

@jihan-lf jihan-lf force-pushed the fix/rhel10-glances branch from dbb0f7c to e0bf877 Compare May 4, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants