added transform to fix rsoxs descriptor#83
Open
Garrett Bischof (gwbischof) wants to merge 1 commit intoNSLS2:mainfrom
Open
added transform to fix rsoxs descriptor#83Garrett Bischof (gwbischof) wants to merge 1 commit intoNSLS2:mainfrom
Garrett Bischof (gwbischof) wants to merge 1 commit intoNSLS2:mainfrom
Conversation
Contributor
Author
|
Fixes #82 |
Contributor
Author
|
based on the PR: bluesky/databroker#474 I thought I was going to have to swap the x,y dims. But i was getting shape errors when I did that. |
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 55.87% 53.39% -2.48%
==========================================
Files 13 13
Lines 809 809
==========================================
- Hits 452 432 -20
- Misses 357 377 +20
Continue to review full report at Codecov.
|
Contributor
Author
|
I made the helper functions, because I suspect that other descriptor transforms will use them too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested a bit with real rsoxs data.. until i ran out of RAM.