Skip to content

refactor: use display names in insights section #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
O2sa merged 1 commit into from
Apr 24, 2026
+9 −6
Merged

refactor: use display names in insights section #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions components/result-dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,21 @@ export function ResultDashboard({ user1, user2 }: Props) {
const getInsights = () => {
const insights: string[] = [];

const user1DisplayName = user1.name || user1.username;
const user2DisplayName = user2.name || user1.username;

if (user1.repoScore > user2.repoScore) {
insights.push(
t("insights.repo.leader", {
username: user1.username,
username: user1DisplayName,
score: user1.repoScore,
other: user2.repoScore,
})
);
} else if (user2.repoScore > user1.repoScore) {
insights.push(
t("insights.repo.leader", {
username: user2.username,
username: user2DisplayName,
score: user2.repoScore,
other: user1.repoScore,
})
Expand All @@ -67,15 +70,15 @@ export function ResultDashboard({ user1, user2 }: Props) {
if (user1.prScore > user2.prScore) {
insights.push(
t("insights.pr.leader", {
username: user1.username,
username: user1DisplayName,
score: user1.prScore,
other: user2.prScore,
})
);
} else if (user2.prScore > user1.prScore) {
insights.push(
t("insights.pr.leader", {
username: user2.username,
username: user2DisplayName,
score: user2.prScore,
other: user1.prScore,
})
Expand All @@ -85,9 +88,9 @@ export function ResultDashboard({ user1, user2 }: Props) {
}

if (user1.contributionScore > user2.contributionScore) {
insights.push(t("insights.contribution.leader", { username: user1.username }));
insights.push(t("insights.contribution.leader", { username: user1DisplayName }));
} else if (user2.contributionScore > user1.contributionScore) {
insights.push(t("insights.contribution.leader", { username: user2.username }));
insights.push(t("insights.contribution.leader", { username: user2DisplayName }));
} else {
insights.push(t("insights.equal.contribution"));
}
Expand Down
Loading