refactor: extract GitHub link into reusable GithubLink component and remove Icon usage#112
Open
BhathiyaVicum wants to merge 3 commits intoO2sa:mainfrom
Open
refactor: extract GitHub link into reusable GithubLink component and remove Icon usage#112BhathiyaVicum wants to merge 3 commits intoO2sa:mainfrom
BhathiyaVicum wants to merge 3 commits intoO2sa:mainfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
|
@BhathiyaVicum is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111
Summary
This PR improves code maintainability by extracting the repeated GitHub link UI into a reusable
GithubLinkcomponent. It also removes the deprecatedIconcomponent usage from multiple places, ensuring consistency and better component structure across the application.Changes
components/github-link.tsxIconusage inThemeTogglewithGithubLinkIconusage inAppFooterwithGithubLinkIconcomponent export fromcomponents/ui/button.tsx✅ Checklist