Draft
Conversation
vaisest
commented
Apr 24, 2026
| if node.oidx == data.orbitIndex and not data.isMastery then | ||
| for _, extendedId in ipairs(importedGroups[proxyGroup].nodes) do | ||
| if id == tonumber(extendedId) and inExtendedHashes(id) then | ||
| if id == extendedId and inExtendedHashes(tonumber(id)) then |
Contributor
Author
There was a problem hiding this comment.
Hopefully this doesn't break anything else. The cluster data is exactly the same as previously, but this seemed to be comparing strings to numbers. Type hints / checking would be really useful here, because I'm not sure what is correct here
Contributor
Author
Contributor
Author
|
The changes seem to break mcagnion's tests, even though the functionality seems to work. I'm not really seeing why that is. Otherwise everything seems to work so far |
Contributor
|
If |
Contributor
Author
Thanks, that was indeed it. Seems very obvious in hindsight lol |
Nightblade
suggested changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I can't find relevant issues, but this primarily fixes annoying issues with POESESSID expiring all the time. For imports, this also automatically adds bandit and pantheon choices, as the OAuth API contains info for them.
Probably enables #5418 via the oauth API, though the current scope does not include
account:stashes.Description of the problem being solved:
Steps taken to verify a working solution:
What this PR still needs
I think this is getting quite close to done, but seeing as it is making a lot of changes to a vital part of the UI, it probably needs a lot more testing. I'm not sure I got all of the differences between the PoE site character data and API data. There might be some legacy things that I don't know about, and I'm not sure about other quirks (like for example the league field in the API is nullable: why?). I also can't test other realm imports since I've only ever played on PC.
The account name import doesn't seem to report 404s at all. I'm not sure if this ever worked, because the website just results in a 403 for me.
The UI also doesn't remember previous league/realm choices yet.
Questions about the UX/UI design were also raised on Discord.
Link to a build that showcases this PR:
N/A
Before screenshot:
After screenshot: