Open
Conversation
0d6f5f0 to
c185a1d
Compare
Member
|
hi @Dropries thanks for the PR. If you are willing to help again I'd like to remove all these We currently don't have any docs documenting it. It occurs only in some places, so I'd say it's time to remove it. It would be nice to re-do the work you've done by completely removing the placeholder and add only the right language wording. Then we could also remove the current logic that is now replacing the placeholder. Can you work on this? |
[]() placeholders
keep slug name for czech translations not referenced on bulbapedia
also remove the '$' and '%' characters around 'effect_chance' in 'move_effect_prose.csv'
v2 to rerun checks
e637c0d to
966a0d7
Compare
Contributor
Author
|
Done, there aren't any |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
This is a large stylistic PR that aims to ensure that the API return proses in a single language. When a prose contains
[]{a:b}, this pattern is replaced byb, which exists only in English, resulting in sentences mixing foreign languages and a single English wordb.In each
data/v2/csv/~_prose.csvfile, I replaced all empty square brackets of the form[]{a:b}by[c]{a:b}wherecis obtained from thedata/v2/csv/a_names.csvfile based on thelocal_language_idof the prose.A few German
[]{mechanic:b}are still empty because there is no file containing the translation of mechanics and I don't really know German...AI coding assistance disclosure
None
Contributor check list