Skip to content

Remove all []() placeholders#1501

Open
Dropries wants to merge 8 commits intoPokeAPI:masterfrom
Dropries:complete-proses
Open

Remove all []() placeholders#1501
Dropries wants to merge 8 commits intoPokeAPI:masterfrom
Dropries:complete-proses

Conversation

@Dropries
Copy link
Copy Markdown
Contributor

Change description

This is a large stylistic PR that aims to ensure that the API return proses in a single language. When a prose contains []{a:b}, this pattern is replaced by b, which exists only in English, resulting in sentences mixing foreign languages and a single English word b.

In each data/v2/csv/~_prose.csv file, I replaced all empty square brackets of the form []{a:b} by [c]{a:b} where c is obtained from the data/v2/csv/a_names.csv file based on the local_language_id of the prose.

A few German []{mechanic:b} are still empty because there is no file containing the translation of mechanics and I don't really know German...

AI coding assistance disclosure

None

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@Naramsim
Copy link
Copy Markdown
Member

hi @Dropries thanks for the PR. If you are willing to help again I'd like to remove all these [](). They were a part of Veekuns data and probably they used that placeholder to link resources internally in their website.

We currently don't have any docs documenting it. It occurs only in some places, so I'd say it's time to remove it. It would be nice to re-do the work you've done by completely removing the placeholder and add only the right language wording.

Then we could also remove the current logic that is now replacing the placeholder. Can you work on this?

@Dropries Dropries changed the title Complete empty square brackets of proses Remove all []() placeholders Apr 24, 2026
Dropries and others added 6 commits April 24, 2026 18:30
keep slug name for czech translations not referenced on bulbapedia
also remove the '$' and '%' characters around 'effect_chance' in
'move_effect_prose.csv'
@Dropries
Copy link
Copy Markdown
Contributor Author

Done, there aren't any []{} left !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants