E2E - QA: init, deploy, versions list, config link, 2nd deploy#7367
Open
phyllis-sy-wu wants to merge 1 commit intopsyw-0421-E2E-teardown-polishfrom
Open
E2E - QA: init, deploy, versions list, config link, 2nd deploy#7367phyllis-sy-wu wants to merge 1 commit intopsyw-0421-E2E-teardown-polishfrom
phyllis-sy-wu wants to merge 1 commit intopsyw-0421-E2E-teardown-polishfrom
Conversation
This was referenced Apr 22, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/analytics.d.ts@@ -19,7 +19,6 @@ interface EnvironmentData {
env_device_id: string;
env_cloud: string;
env_package_manager: string;
- env_install_package_manager: string;
env_is_global: boolean;
env_auth_method: string;
env_is_wsl: boolean;
packages/cli-kit/dist/public/node/monorail.d.ts@@ -2,7 +2,7 @@ import { JsonMap } from '../../private/common/json.js';
import { DeepRequired } from '../common/ts/deep-required.js';
export { DeepRequired };
type Optional<T> = T | null;
-export declare const MONORAIL_COMMAND_TOPIC = "app_cli3_command/1.22";
+export declare const MONORAIL_COMMAND_TOPIC = "app_cli3_command/1.21";
export interface Schemas {
[MONORAIL_COMMAND_TOPIC]: {
sensitive: {
@@ -129,7 +129,6 @@ export interface Schemas {
env_ci_platform?: Optional<string>;
env_device_id?: Optional<string>;
env_package_manager?: Optional<string>;
- env_install_package_manager?: Optional<string>;
env_package_manager_workspaces?: Optional<boolean>;
env_plugin_installed_any_custom?: Optional<boolean>;
env_plugin_installed_shopify?: Optional<string>;
|
9d0a3aa to
bfb1932
Compare
26a7e70 to
95f628a
Compare
95f628a to
f0005dd
Compare
bfb1932 to
d892ee8
Compare
Open
f0005dd to
633cc3c
Compare
633cc3c to
8e559ab
Compare
21fd11c to
64ab746
Compare
64ab746 to
9fdc90b
Compare
8e559ab to
64d0528
Compare
64d0528 to
e952944
Compare
9fdc90b to
9ef5dba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Automates test A of the manual QA flow (tracked in #7368 / sub-issue #7369). The existing
app-deploy.spec.tsonly covered a single init→deploy→versions-list cycle. Test A extends it to the full manual flow, adding coverage for:app config linkcreating a second app (interactive PTY prompts)This closes the gap for the
config link-to-new-app codepath, which previously had no E2E coverage.WHAT is this pull request doing?
Expands
tests/app-deploy.spec.tsto the full A scope:shopify app init --template reactRouter(primary app)shopify app deploy --version v1+ assert active on primaryshopify app versions list --json+ assertversionTagmatchesshopify app config link --config secondary(via PTY) → creates a new app within the primary app's organizationshopify app deploy --config secondary --version v2+ assert active on secondaryshopify app versions list --config secondary --json+ assert isolation from primaryAlso adds helpers in
setup/app.ts(config-link PTY driver, JSON-mode versions list, shared assertion for active-version checks) reused across this and future A–F tests.How to test your changes?
Requires
.envwithE2E_ACCOUNT_EMAIL,E2E_ACCOUNT_PASSWORD,E2E_ORG_ID.Runtime ~2 min. Resources created during the test are the two apps (primary + secondary) — teardown deletes both automatically.
Example
Expand for complete log
Post-release steps
N/A
Checklist