Organize the Matter Switch field naming conventions#2922
Open
hcarter-775 wants to merge 1 commit intomake-configurable/stateless-transition-timefrom
Open
Organize the Matter Switch field naming conventions#2922hcarter-775 wants to merge 1 commit intomake-configurable/stateless-transition-timefrom
hcarter-775 wants to merge 1 commit intomake-configurable/stateless-transition-timefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Done in response to this comment, which made me think that if we were going to try to make a COLOR_TEMP_STEP table, what we really wanted was a COLOR_TEMP table that holds all the color temp-related fields. Then, to make this make sense with all the other assorted fields, I re-organized most of them into structures like this, which I think makes what field is associated with what make more sense from a top-down way.
However, since this is clearly a larger change than was initially suggested, I put this in its own PR for separate review.
As we can see, none of the tests were actually changed, as none of the driver functionality was changed in any way, just the naming conventions.
Summary of Completed Tests