fix unit presence time_range#4571
Open
tayheau wants to merge 2 commits intoSpikeInterface:mainfrom
Open
Conversation
for more information, see https://pre-commit.ci
Member
|
@tayheau add some description to the PR please! |
chrishalcrow
reviewed
May 1, 2026
Comment on lines
+116
to
+118
| im = self.ax.imshow( | ||
| map, cmap="inferno", aspect="auto", interpolation="nearest", extent=extent, vmax=1.0, vmin=0.0 | ||
| ) |
Member
There was a problem hiding this comment.
Just curious - why switch from matshow to imshow?
chrishalcrow
approved these changes
May 1, 2026
Member
chrishalcrow
left a comment
chrishalcrow
left a comment
There was a problem hiding this comment.
Fixes bug in time_range for plot_unit_presence- thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix time_range support by handling duration/offset properly when time_range is set + switch from matshow to imshow with correct extent