Introduce explicit top-level multi-embedding configuration#16
Merged
Vladyslav-Kuksiuk merged 9 commits intomasterfrom May 5, 2026
Merged
Introduce explicit top-level multi-embedding configuration#16Vladyslav-Kuksiuk merged 9 commits intomasterfrom
Vladyslav-Kuksiuk merged 9 commits intomasterfrom
Conversation
dmytro-kashcheiev
approved these changes
May 4, 2026
Collaborator
dmytro-kashcheiev
left a comment
dmytro-kashcheiev
left a comment
There was a problem hiding this comment.
@Vladyslav-Kuksiuk LGTM with two minor things to check before the merge.
Comment on lines
+149
to
+152
| * `embeddings`: (Optional) A list of complete embedding configurations for multiple | ||
| documentation targets. When `embeddings` is set, do not set root-level `code-path` | ||
| or `docs-path`. Define `code-path`, `docs-path`, and optional settings inside each entry. | ||
| Each entry must set a unique `name`. |
Collaborator
There was a problem hiding this comment.
If both options set, it should throw with meaningfull message to make configuration issues clear.
Comment on lines
+167
to
+168
| // Validates one embedding entry. | ||
| func validateEmbeddingConfig(embedding EmbeddingConfig, index int) error { |
Collaborator
There was a problem hiding this comment.
Not sure if this and the above doc style match the GO best practices.
Below, you start with the function name. Did I miss something?
Contributor
|
@Vladyslav-Kuksiuk, please update the title of the PR with precise description of the feature. "Update configuration behaviour" is too generic. |
Vladyslav-Kuksiuk
changed the title
# Conflicts: # bin/embed-code-linux # bin/embed-code-macos # bin/embed-code-windows.exe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates how multiple embedding configurations are set. Resolves this issue.
Changes:
embed-mappingsstructure with explicit top-levelembeddings.fragments-path/<embedding-name>.docs-pathvalues.