Conversation
Collaborator
Author
|
force pushed because i forgot to fix the stats area in |
activity.py leaves a lot to be desired
This comment was marked as outdated.
This comment was marked as outdated.
i think this escapes stuff. we probably want that
also the reformatter...
not a great refactor but cli is low priority right now
Collaborator
Author
|
sigh, the rest of the issues are in the editor submodule |
Collaborator
Author
|
tbh some of the base classes in editor/base are kinda useless. im not using the base classes for generic stuff so idk what the point is. might be worth getting rid of them. but i was planning on a rewrite of sa.editor in rust for other reasons as well. i am not sure if it is worth reducing the complexity of sa.editor. |
Collaborator
Author
|
i might just add some type: ignore comments around sa.editor to disable the mccabe complexity in there. because based on what I plan, it would become redundant soon anyway. unless someone else wants to change that. |
I plan on a rewrite, not a refactor here #596 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue #566
Changes
This PR re-enables the mccabe complexity check with ruff and resolves the existing functions which are too complex
Tests
N/A, would be checked by gh actions; there is work to be done there