Skip to content

chore(docs): sync supply-chain record with pyproject after #531/#553 [PYSDK-114]#605

Merged
helmut-hoffer-von-ankershoffen merged 2 commits intomainfrom
fix/PYSDK-114-audit-doc-sync
Apr 27, 2026
Merged

chore(docs): sync supply-chain record with pyproject after #531/#553 [PYSDK-114]#605
helmut-hoffer-von-ankershoffen merged 2 commits intomainfrom
fix/PYSDK-114-audit-doc-sync

Conversation

@helmut-hoffer-von-ankershoffen
Copy link
Copy Markdown
Contributor

@helmut-hoffer-von-ankershoffen helmut-hoffer-von-ankershoffen commented Apr 27, 2026

🛡️ Resolves PYSDK-114. Governed by PR-SOP-01 Problem Resolution and Non-Conforming Products.

Why this PR exists

make audit on main is green and every pyproject.toml lower bound correctly protects downstream consumers — including for the two CVE-driven bot bumps in this PR's scope. But the auditable record in SUPPLY_CHAIN_VULNERABILITIES.md and one inline annotation in pyproject.toml lag behind reality after merges of #531 (nicegui) and #553 (nbconvert). Reviewers reading the doc would see a snapshot inconsistent with the metadata published to PyPI.

This PR closes that gap. It is a pure record-keeping fix — no version constraint changes, no uv lock regeneration, no consumer-visible behaviour change.

Key property: no dependency was upgraded

Every existing lower bound in pyproject.toml is preserved. The diff only:

  • raises one row's Constraint column in SUPPLY_CHAIN_VULNERABILITIES.md to match what is already in pyproject.toml
  • extends two rows' Protects against columns with CVE ids whose fixes the existing bound already enforces
  • rewrites one inline # CVE-… annotation in pyproject.toml to name the CVEs whose fixes the bound already enforces

What changed

SUPPLY_CHAIN_VULNERABILITIES.mdnicegui[native] row (line 104)

SUPPLY_CHAIN_VULNERABILITIES.mdnbconvert row (line 124)

  • Protects-against list: extended with CVE-2026-39377 (>=7.17.1) and CVE-2026-39378 (>=7.17.1) (both CVSS 6.5 Medium). Existing CVE-2025-53000 (>=7.17.0) reformatted to match the rest of the table's "since-which-version" convention.
  • Severity stays High (max across the protected CVEs).

pyproject.tomlnbconvert inline annotation (line 158)

- "nbconvert>=7.17.1",  # CVE-2025-53000 (>=7.17.0, Dependabot #424); Dependabot #553 raised to 7.17.1
+ "nbconvert>=7.17.1",  # CVE-2025-53000 (>=7.17.0, Dependabot #424); CVE-2026-39377, CVE-2026-39378 (>=7.17.1, Dependabot #553)

Accepted advisories — unchanged

The only entry in the Active acceptances table is CVE-2026-3219 (pip archive type confusion, dev-only, no upstream fix released yet). Re-verified this run: still warranted; pip 26.0.1 is the latest, fix is in unreleased pip 26.1.

Auditable record — changes to SUPPLY_CHAIN_VULNERABILITIES.md

Active acceptances — added: none. — removed: none. — changed: none.

Enforced lower bounds — raised

  • nicegui[native] >=3.9.0,<4>=3.11.0,<4 — adds documented protection against CVE-2026-39844 (Medium).

Enforced lower bounds — annotation only (no version change)

  • nbconvert >=7.17.1: Protects against extended with CVE-2026-39377 (Medium) and CVE-2026-39378 (Medium); severity stays High.

Test plan

  • make audit green (only the existing CVE-2026-3219 ignore fires; still justified)
  • make lint green
  • make test_unit green
  • Manual cross-check: every CVE/GHSA id in updated SUPPLY_CHAIN_VULNERABILITIES.md rows matches an inline # CVE-… annotation in pyproject.toml and vice versa
  • Manual cross-check: every pyproject.toml lower bound covered by an updated row equals or exceeds the doc-row constraint

Out of scope

  • New CVE remediation — none surfaced this run.
  • Sort-order rot of the Enforced lower bounds table (rows from 2025-12-10 interleaved with 2026-04-24) — pre-existing, not introduced here. A separate audit-skill enhancement is being requested.

🤖 Generated with Claude Code

…[PYSDK-114]

The auditable record in SUPPLY_CHAIN_VULNERABILITIES.md and one inline
annotation in pyproject.toml lagged behind reality after Renovate #531
(nicegui 3.9.0 -> 3.11.0, citing CVE-2026-39844) and Dependabot #553
(nbconvert 7.17.0 -> 7.17.1, citing CVE-2026-39377 + CVE-2026-39378)
were merged. The lower bounds in pyproject.toml were correctly raised at
merge time, so no consumer was exposed; the gap was purely in the
reviewer-facing record.

This is a record-keeping fix only: no version constraint changes, no
uv.lock regeneration, no consumer-visible behaviour change. Every
existing pyproject.toml lower bound is preserved.

Discovered by the pysdk-audit-daily routine on 2026-04-27 during the
clean-audit no-op path (Step 1b/1d.1 bot-PR walk).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 27, 2026 07:59
@helmut-hoffer-von-ankershoffen helmut-hoffer-von-ankershoffen requested a review from a team as a code owner April 27, 2026 07:59
@helmut-hoffer-von-ankershoffen helmut-hoffer-von-ankershoffen added skip:test:long_running Skip long-running tests (≥5min) sop:pr-sop-01 PR-SOP-01 Problem Resolution (bug / anomaly fix) type:docs Documentation-only change security:supply-chain Supply-chain (dependency) vulnerability remediation auto-merge Eligible for auto-merge once CI is green labels Apr 27, 2026
@helmut-hoffer-von-ankershoffen helmut-hoffer-von-ankershoffen marked this pull request as draft April 27, 2026 07:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes the project’s auditable supply-chain vulnerability record (SUPPLY_CHAIN_VULNERABILITIES.md) and inline CVE annotations in pyproject.toml with dependency lower bounds that are already enforced (post-#531 and #553), keeping the documentation consistent with published metadata.

Changes:

  • Update the nicegui[native] row in SUPPLY_CHAIN_VULNERABILITIES.md to reflect the already-enforced >=3.11.0,<4 constraint and include CVE-2026-39844 in the protected set.
  • Expand the nbconvert row in SUPPLY_CHAIN_VULNERABILITIES.md to include CVE-2026-39377 and CVE-2026-39378 (while preserving the existing lower bound).
  • Refine the inline nbconvert CVE annotation in pyproject.toml to match the CVEs protected by the existing >=7.17.1 bound.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pyproject.toml Updates the nbconvert inline CVE annotation under the jupyter extra to reflect current protected CVEs.
SUPPLY_CHAIN_VULNERABILITIES.md Updates enforced-lower-bound records for nicegui[native] and nbconvert to match pyproject.toml and current CVE coverage.

@helmut-hoffer-von-ankershoffen helmut-hoffer-von-ankershoffen marked this pull request as ready for review April 27, 2026 08:08
Copilot AI review requested due to automatic review settings April 27, 2026 08:08
@helmut-hoffer-von-ankershoffen helmut-hoffer-von-ankershoffen merged commit 3ee8ac2 into main Apr 27, 2026
5 checks passed
@helmut-hoffer-von-ankershoffen helmut-hoffer-von-ankershoffen deleted the fix/PYSDK-114-audit-doc-sync branch April 27, 2026 08:08
@claude
Copy link
Copy Markdown

claude Bot commented Apr 27, 2026

Claude finished @helmut-hoffer-von-ankershoffen's task in 5m 7s —— View job


Review Complete ✅

I've completed a comprehensive review of PR #605 — a documentation synchronization for supply chain vulnerabilities.


Summary

This PR correctly synchronizes SUPPLY_CHAIN_VULNERABILITIES.md with pyproject.toml after dependency bumps in #531 (nicegui) and #553 (nbconvert). No version constraints were changed — this is pure record-keeping.

What Was Reviewed

3 Documentation Updates:

All Critical Checks Passed:

  • Conventional commits (chore(docs): format)
  • Code quality (ruff check passed)
  • Security audit (make audit green, CVE-2026-3219 properly accepted)
  • Documentation accuracy (all CVEs match between doc and pyproject.toml)

Cross-Validation:

  • nicegui[native] constraint in pyproject.toml line 81 matches doc line 104
  • nbconvert constraint in pyproject.toml line 158 matches doc line 124
  • All inline CVE comments match "Protects against" columns

Verdict

✅ claude:review:passed

This is exemplary supply chain management — proactive (discovered by automated audit), thorough (all CVEs cross-referenced), and transparent (clear documentation of what changed and why).

Zero risk: No consumer-visible changes, only documentation brought into sync with reality.


📝 Full review posted as PR comment
🏷️ Label applied: claude:review:passed
🔗

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@claude claude Bot added the claude:review:passed Automated Claude PR review found no blocking issues on the current head commit label Apr 27, 2026
@claude
Copy link
Copy Markdown

claude Bot commented Apr 27, 2026

🤖 Claude Code Review Complete

I've completed my review of this supply chain vulnerability documentation sync PR.

Summary

This PR correctly synchronizes the auditable record in SUPPLY_CHAIN_VULNERABILITIES.md with the actual dependency constraints in pyproject.toml after merges of #531 (nicegui 3.9.0→3.11.0) and #553 (nbconvert 7.17.0→7.17.1).

Key Property: No dependency version changes — constraints in pyproject.toml were already correct. This is purely a record-keeping fix to bring documentation into sync.

What Was Verified

Documentation Accuracy: All CVE references and version constraints in the doc table match pyproject.toml exactly
Security Audit: make audit passes (only CVE-2026-3219 properly accepted)
Code Quality: ruff check passes
Conventional Commits: Proper chore(docs): format
Zero Risk: No consumer-visible changes

Cross-Reference Validation

Package pyproject.toml SUPPLY_CHAIN_VULNERABILITIES.md Match
nicegui[native] >=3.11.0,<4 (line 81) >=3.11.0,<4 (line 104)
nbconvert >=7.17.1 (line 158) >=7.17.1 (line 124)

All inline CVE comments match the "Protects against" columns.

Verdict

✅ claude:review:passed

This is exemplary supply chain management — proactive, thorough, and transparent. The PR description clearly explains the gap (doc lagged after bot PRs merged) and what changed (three documentation updates, zero version bumps).


Review completed by Claude Code | View detailed review | View job run

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.
see 20 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Eligible for auto-merge once CI is green claude:review:passed Automated Claude PR review found no blocking issues on the current head commit security:supply-chain Supply-chain (dependency) vulnerability remediation skip:test:long_running Skip long-running tests (≥5min) sop:pr-sop-01 PR-SOP-01 Problem Resolution (bug / anomaly fix) type:docs Documentation-only change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants