Open
Conversation
pseusys
previously approved these changes
May 2, 2024
Contributor
Author
|
It appears that a previous CI failure is blocking this pull request. I will push a new commit to trigger the CI again and work on resolving the issue. |
nxstd
approved these changes
Sep 30, 2024
| :param length: The length to pad the string to. | ||
| :returns: The padded or truncated string. | ||
| """ | ||
| width = wcswidth(string) |
There was a problem hiding this comment.
The wcswidth function can return -1 when the string contains non-printable characters (e.g., control characters). This will cause incorrect behavior in the padding logic. Consider adding a check to handle this case, for example by falling back to using len(string) when wcswidth returns -1.
Suggested change
| width = wcswidth(string) | |
| width = wcswidth(string) | |
| if width < 0: | |
| # Fallback for strings with non-printable characters where wcswidth returns -1. | |
| width = len(string) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute unicode display width instead of string length.
Before:
After:
Preview: