Handle missing streaming thinking signatures#181
Open
xoofx wants to merge 1 commit intoanthropics:nextfrom
Open
Handle missing streaming thinking signatures#181xoofx wants to merge 1 commit intoanthropics:nextfrom
xoofx wants to merge 1 commit intoanthropics:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup from #180
Summary
signaturesignaturefrom raw JSON opportunistically for thinking blocks in both the standard and beta adapterssignature_deltaWhy
MiniMax''s Anthropic-compatible streaming API sends a
thinkingcontent block without an initialsignature, then emits the signature later as asignature_delta. The current adapters accessthinking.Signatureeagerly, which throws before the stream can continue.This change keeps the existing
signature_deltahandling, but avoids assuming the initial block always includes a signature.Testing
dotnet test src/Anthropic.Tests/Anthropic.Tests.csproj -c Release --no-restore --filter "GetStreamingResponseAsync_WithThinkingBlockMissingInitialSignature_DoesNotThrow|GetStreamingResponseAsync_WithThinkingBlockInStream|GetStreamingResponseAsync_WithSignatureDeltaInStream"