Skip to content

[Dataflow] Added Portable Runner Passing for Python/Go Runners#38375

Open
TongruiLi wants to merge 2 commits intoapache:masterfrom
TongruiLi:master
Open

[Dataflow] Added Portable Runner Passing for Python/Go Runners#38375
TongruiLi wants to merge 2 commits intoapache:masterfrom
TongruiLi:master

Conversation

@TongruiLi
Copy link
Copy Markdown
Contributor

@TongruiLi TongruiLi commented May 6, 2026

Added Portable Runner Passing for Python/Go Runners. This includes the following experiment options

  1. enable_portable_runner as a valid option for enabling runner v2
  2. disable_portable_runner/enable_streaming_java_runner for disabling runner v2. Specifying these options will cause the job to be rejected.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for the portable runner in Python by adding 'enable_portable_runner' as a configuration experiment. It also enhances the Runner v2 validation logic to ensure that specific experimental flags correctly trigger the disabling of Runner v2, maintaining consistency across job submission configurations.

Highlights

  • Portable Runner Support: Added 'enable_portable_runner' as a valid experiment option to support Runner v2.
  • Runner v2 Disabling: Updated logic to disable Runner v2 when 'disable_portable_runner' or 'enable_streaming_java_runner' experiments are specified.
  • Test Coverage: Updated existing unit tests in dataflow_runner_test.py to include 'enable_portable_runner' in validation checks.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the enable_portable_runner, disable_portable_runner, and enable_streaming_java_runner experiments to the Dataflow runner and updates the test suite to verify their presence. Feedback suggests that enable_portable_runner should be integrated into the detection logic to correctly trigger Runner V2. Additionally, it is recommended to implement explicit validation to reject jobs when disable_portable_runner or enable_streaming_java_runner are specified, ensuring the behavior aligns with the intended job rejection rather than falling back to the legacy runner.

debug_options.add_experiment('use_unified_worker')
debug_options.add_experiment('use_runner_v2')
debug_options.add_experiment('use_portable_job_submission')
debug_options.add_experiment('enable_portable_runner')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR description states that enable_portable_runner is a valid option for enabling Runner V2. However, this flag is currently only added to the experiments list within _add_runner_v2_missing_options, which is typically called after the decision to use Runner V2 has already been made. To fully support this flag as a trigger for Runner V2, it should also be included in the detection logic (e.g., in _is_runner_v2_enabled or the logic that calls _add_runner_v2_missing_options).

Comment on lines +666 to +667
debug_options.lookup_experiment('disable_portable_runner') or
debug_options.lookup_experiment('enable_streaming_java_runner') or
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR description mentions that specifying disable_portable_runner or enable_streaming_java_runner should cause the job to be rejected. Currently, these flags are only added to _is_runner_v2_disabled, which prevents Runner V2 flags from being added but allows the job to potentially fall back to the legacy runner. If a hard rejection is intended as described, please add an explicit validation check that raises an exception when these experiments are present.

@TongruiLi TongruiLi changed the title Added Portable Runner Passing for Python Runners Added Portable Runner Passing for Python/Go Runners May 6, 2026
@TongruiLi TongruiLi changed the title Added Portable Runner Passing for Python/Go Runners [Dataflow] Added Portable Runner Passing for Python/Go Runners May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Assigning reviewers:

R: @shunping for label python.
R: @shunping for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant