[Dataflow] Added Portable Runner Passing for Python/Go Runners#38375
[Dataflow] Added Portable Runner Passing for Python/Go Runners#38375TongruiLi wants to merge 2 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for the portable runner in Python by adding 'enable_portable_runner' as a configuration experiment. It also enhances the Runner v2 validation logic to ensure that specific experimental flags correctly trigger the disabling of Runner v2, maintaining consistency across job submission configurations. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the enable_portable_runner, disable_portable_runner, and enable_streaming_java_runner experiments to the Dataflow runner and updates the test suite to verify their presence. Feedback suggests that enable_portable_runner should be integrated into the detection logic to correctly trigger Runner V2. Additionally, it is recommended to implement explicit validation to reject jobs when disable_portable_runner or enable_streaming_java_runner are specified, ensuring the behavior aligns with the intended job rejection rather than falling back to the legacy runner.
| debug_options.add_experiment('use_unified_worker') | ||
| debug_options.add_experiment('use_runner_v2') | ||
| debug_options.add_experiment('use_portable_job_submission') | ||
| debug_options.add_experiment('enable_portable_runner') |
There was a problem hiding this comment.
The PR description states that enable_portable_runner is a valid option for enabling Runner V2. However, this flag is currently only added to the experiments list within _add_runner_v2_missing_options, which is typically called after the decision to use Runner V2 has already been made. To fully support this flag as a trigger for Runner V2, it should also be included in the detection logic (e.g., in _is_runner_v2_enabled or the logic that calls _add_runner_v2_missing_options).
| debug_options.lookup_experiment('disable_portable_runner') or | ||
| debug_options.lookup_experiment('enable_streaming_java_runner') or |
There was a problem hiding this comment.
The PR description mentions that specifying disable_portable_runner or enable_streaming_java_runner should cause the job to be rejected. Currently, these flags are only added to _is_runner_v2_disabled, which prevents Runner V2 flags from being added but allows the job to potentially fall back to the legacy runner. If a hard rejection is intended as described, please add an explicit validation check that raises an exception when these experiments are present.
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Added Portable Runner Passing for Python/Go Runners. This includes the following experiment options
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.