Stabilize StorageApiDataTriggeredSchemaUpdateIT assertion#38339
Stabilize StorageApiDataTriggeredSchemaUpdateIT assertion#38339aIbrahiim wants to merge 4 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on stabilizing integration tests within the Google Cloud Platform IO module. By adjusting stream configurations and relaxing strict assertion requirements to accommodate race conditions and non-deterministic behavior in distributed environments, the changes improve the reliability of the test suite. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates integration tests for BigQuery and GCS to handle non-deterministic behavior in Dataflow environments. In StorageApiDataTriggeredSchemaUpdateIT, the test now uses a custom verifier for dead-letter queue rows to account for potential races during schema upgrades, and the number of storage write streams was reduced to one. In GcsMatchIT, the assertion for file size sums was changed to a range-based check to accommodate skipped updates during continuous matching. Feedback was provided regarding a potential integer overflow in the new calculation for the minimum possible sum in GcsMatchIT.
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Related to #30730
Successful run: https://github.com/apache/beam/actions/runs/25366036447/job/74377001518?pr=38339
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.