remove processContext usage across examples (java and kotlin)#38366
remove processContext usage across examples (java and kotlin)#38366stankiewicz wants to merge 1 commit intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the Apache Beam examples by migrating away from the deprecated ProcessContext API in favor of more explicit and type-safe parameter injection. These changes improve code clarity and align the examples with current best practices for writing DoFns in both Java and Kotlin. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates numerous Java examples to align with the new DoFn.ProcessElement method signature, which now uses explicit annotations like @Element, @OutputReceiver, @SideInput, @Timestamp, and PaneInfo instead of ProcessContext. This refactoring affects a wide range of examples, including those demonstrating Iceberg, SQL, various core transforms, complete examples, data tokenization utilities, game examples, and cookbook examples. Additionally, the CsvConverters utility was refactored to introduce a new FailsafeElementToJsonWithHeadersFn for handling CSVs with headers, and the WriteToBigQuery and WriteToText utilities were updated to reflect the new DoFn parameter structure. Review feedback suggests removing an unused variable (headersView) in CsvConverters.java for code cleanup.
…t provider Starting with examples for java and kotlin.
e25dd47 to
7629e32
Compare
| } | ||
| } | ||
|
|
||
| public static class FailsafeElementToJsonWithHeadersFn |
There was a problem hiding this comment.
What is the consideration to branching the DoFn here? Is necessary to have a separate DoFn with/without side input under recommended OutputReceiver pattern? Ideally we can avoid duplicated codes if possible
There was a problem hiding this comment.
@kennknowles to chip in. we discussed that it's anti-pattern to have nullable side input.
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
validation:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.