Skip to content

Add DiskProvisionedIops/ThroughputMibps pipeline options for the Python SDK#38370

Open
bambadiouf1 wants to merge 11 commits intoapache:masterfrom
bambadiouf1:restore-disk-opts-python
Open

Add DiskProvisionedIops/ThroughputMibps pipeline options for the Python SDK#38370
bambadiouf1 wants to merge 11 commits intoapache:masterfrom
bambadiouf1:restore-disk-opts-python

Conversation

@bambadiouf1
Copy link
Copy Markdown
Contributor

This pull request introduces two new pipeline options for the Google Cloud Dataflow runner for the python SDK. These options allow users to specify provisioned performance for worker VM disks:

disk_provisioned_iops: Sets the provisioned IOPS for the disk. If unspecified, the service chooses a default
disk_provisioned_throughput_mibps: Sets the provisioned throughput in MiB/s for the disk.

Tests have been added/updated to verify that these options are correctly parsed and translated.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Google Cloud Dataflow runner for the Python SDK by introducing support for fine-grained disk performance configuration. Users can now explicitly define provisioned IOPS and throughput for worker VM disks, providing greater control over resource performance in Dataflow pipelines.

Highlights

  • New Pipeline Options: Added --disk_provisioned_iops and --disk_provisioned_throughput_mibps options to the Python SDK for Google Cloud Dataflow.
  • Dataflow API Integration: Updated the Dataflow API client to propagate these new disk performance settings to the worker pool configuration.
  • Testing: Added comprehensive unit tests to verify correct parsing of the new options and their translation into the API request.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new pipeline options, --disk_provisioned_iops and --disk_provisioned_throughput_mibps, which allow users to configure provisioned IOPS and throughput for worker disks in the Dataflow runner. The changes include updates to the pipeline options parser, the Dataflow API client, and internal message definitions, supported by new unit tests. Feedback was provided regarding the need to update CHANGES.md with a description of these new features, as the current change to that file only involves whitespace.

Comment thread CHANGES.md
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Assigning reviewers:

R: @tvalentyn for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

defaultPackageSet: The default package set to install. This allows the
service to select a default set of packages which are useful to worker
harnesses written in a particular language.
diskProvisionedIops: Optional. IOPS provisioned for the root disk for VMs.
Copy link
Copy Markdown
Contributor

@tvalentyn tvalentyn May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe this file is normally autogenerated. was this a manual change?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @jrmccluskey -- anything to watch out for here regarding your work on deprecating apitools?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants