Add DiskProvisionedIops/ThroughputMibps pipeline options for the Python SDK#38370
Add DiskProvisionedIops/ThroughputMibps pipeline options for the Python SDK#38370bambadiouf1 wants to merge 11 commits intoapache:masterfrom
Conversation
…ns to pipeline configuration
…m into restore-disk-opts-python
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Google Cloud Dataflow runner for the Python SDK by introducing support for fine-grained disk performance configuration. Users can now explicitly define provisioned IOPS and throughput for worker VM disks, providing greater control over resource performance in Dataflow pipelines. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces two new pipeline options, --disk_provisioned_iops and --disk_provisioned_throughput_mibps, which allow users to configure provisioned IOPS and throughput for worker disks in the Dataflow runner. The changes include updates to the pipeline options parser, the Dataflow API client, and internal message definitions, supported by new unit tests. Feedback was provided regarding the need to update CHANGES.md with a description of these new features, as the current change to that file only involves whitespace.
|
Assigning reviewers: R: @tvalentyn for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| defaultPackageSet: The default package set to install. This allows the | ||
| service to select a default set of packages which are useful to worker | ||
| harnesses written in a particular language. | ||
| diskProvisionedIops: Optional. IOPS provisioned for the root disk for VMs. |
There was a problem hiding this comment.
i believe this file is normally autogenerated. was this a manual change?
There was a problem hiding this comment.
cc: @jrmccluskey -- anything to watch out for here regarding your work on deprecating apitools?
This pull request introduces two new pipeline options for the Google Cloud Dataflow runner for the python SDK. These options allow users to specify provisioned performance for worker VM disks:
disk_provisioned_iops: Sets the provisioned IOPS for the disk. If unspecified, the service chooses a default
disk_provisioned_throughput_mibps: Sets the provisioned throughput in MiB/s for the disk.
Tests have been added/updated to verify that these options are correctly parsed and translated.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.