Skip to content

Upgrade to Avro 1.12#38373

Open
Abacn wants to merge 1 commit intoapache:masterfrom
Abacn:bump-avro
Open

Upgrade to Avro 1.12#38373
Abacn wants to merge 1 commit intoapache:masterfrom
Abacn:bump-avro

Conversation

@Abacn
Copy link
Copy Markdown
Contributor

@Abacn Abacn commented May 5, 2026

Fix #34993

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request upgrades the Apache Beam project's Avro dependency to version 1.12.0. The changes involve updating build configurations, removing redundant test modules that were previously used as workarounds, and refactoring test code to improve maintainability and version verification. Several tests have been annotated with notes regarding known issues in the new Avro version.

Highlights

  • Avro Version Upgrade: Upgraded the project-wide Avro dependency to version 1.12.0.
  • Test Infrastructure Cleanup: Removed the 'vendored-test' module for Avro as it is no longer required for testing with the new version.
  • Codebase Refactoring: Centralized Avro version retrieval in AvroUtils and updated multiple test classes to use this helper, while adding notes for known test failures related to AVRO-4209.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/README.md
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the Avro dependency to version 1.12.0, removes the vendored test module, and centralizes Avro version detection within AvroUtils. Feedback identifies a missing Schema import in AvroSourceTest.java required by the updated readString signature and recommends defensive null-handling for the Avro version string to prevent potential NullPointerExceptions in environments where manifest information is unavailable.

*/
package org.apache.beam.sdk.extensions.avro.io;

import static org.apache.beam.sdk.extensions.avro.schemas.utils.AvroUtils.VERSION_AVRO;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Schema class is used in the updated readString method signature later in this file (lines 563 and 565), but it is not imported. This will cause a compilation error. Adding the import here resolves the issue.

Suggested change
import static org.apache.beam.sdk.extensions.avro.schemas.utils.AvroUtils.VERSION_AVRO;
import static org.apache.beam.sdk.extensions.avro.schemas.utils.AvroUtils.VERSION_AVRO;
import org.apache.avro.Schema;

Comment on lines +159 to +160
public static final String VERSION_AVRO =
org.apache.avro.Schema.class.getPackage().getImplementationVersion();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The getImplementationVersion() method can return null if the manifest information is not available (e.g., when running tests in certain IDEs or environments). Since VERSION_AVRO is used in comparisons like VERSION_AVRO.equals("1.8.2") in other classes (e.g., TestAvroConversionFactory), this could lead to a NullPointerException. It is safer to handle the null case here by providing a default value like an empty string.

Suggested change
public static final String VERSION_AVRO =
org.apache.avro.Schema.class.getPackage().getImplementationVersion();
public static final String VERSION_AVRO =
java.util.Optional.ofNullable(org.apache.avro.Schema.class.getPackage())
.map(java.lang.Package::getImplementationVersion)
.orElse("");

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Upgrade avro to the latest version after Java 8 is deprecated

1 participant