Upgrade to Avro 1.12#38373
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request upgrades the Apache Beam project's Avro dependency to version 1.12.0. The changes involve updating build configurations, removing redundant test modules that were previously used as workarounds, and refactoring test code to improve maintainability and version verification. Several tests have been annotated with notes regarding known issues in the new Avro version. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the Avro dependency to version 1.12.0, removes the vendored test module, and centralizes Avro version detection within AvroUtils. Feedback identifies a missing Schema import in AvroSourceTest.java required by the updated readString signature and recommends defensive null-handling for the Avro version string to prevent potential NullPointerExceptions in environments where manifest information is unavailable.
| */ | ||
| package org.apache.beam.sdk.extensions.avro.io; | ||
|
|
||
| import static org.apache.beam.sdk.extensions.avro.schemas.utils.AvroUtils.VERSION_AVRO; |
There was a problem hiding this comment.
The Schema class is used in the updated readString method signature later in this file (lines 563 and 565), but it is not imported. This will cause a compilation error. Adding the import here resolves the issue.
| import static org.apache.beam.sdk.extensions.avro.schemas.utils.AvroUtils.VERSION_AVRO; | |
| import static org.apache.beam.sdk.extensions.avro.schemas.utils.AvroUtils.VERSION_AVRO; | |
| import org.apache.avro.Schema; |
| public static final String VERSION_AVRO = | ||
| org.apache.avro.Schema.class.getPackage().getImplementationVersion(); |
There was a problem hiding this comment.
The getImplementationVersion() method can return null if the manifest information is not available (e.g., when running tests in certain IDEs or environments). Since VERSION_AVRO is used in comparisons like VERSION_AVRO.equals("1.8.2") in other classes (e.g., TestAvroConversionFactory), this could lead to a NullPointerException. It is safer to handle the null case here by providing a default value like an empty string.
| public static final String VERSION_AVRO = | |
| org.apache.avro.Schema.class.getPackage().getImplementationVersion(); | |
| public static final String VERSION_AVRO = | |
| java.util.Optional.ofNullable(org.apache.avro.Schema.class.getPackage()) | |
| .map(java.lang.Package::getImplementationVersion) | |
| .orElse(""); |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Fix #34993
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.