Use compare_exchange_weak in steal loop for potential performance imp…#3285
Open
xin-ok wants to merge 1 commit intoapache:masterfrom
Open
Use compare_exchange_weak in steal loop for potential performance imp…#3285xin-ok wants to merge 1 commit intoapache:masterfrom
xin-ok wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
在 WorkStealingQueue 的 steal 函数中，使用 compare_exchange_strong 在循环中重试。
由于已经在 do-while 循环中，改用 compare_exchange_weak 可以获得更好的性能，
同时保持语义正确
What is changed and the side effects?
Changed:
_top.compare_exchange_strong改为_top.compare_exchange_weakSide effects:
Check List: