CASSPYTHON-21 Wheels for 3.30.0 include Cython-generated .c files#1291
Open
absurdfarce wants to merge 1 commit intoapache:trunkfrom
Open
CASSPYTHON-21 Wheels for 3.30.0 include Cython-generated .c files#1291absurdfarce wants to merge 1 commit intoapache:trunkfrom
absurdfarce wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
|
Local source dist and wheel builds indicate that the C files are now excluded: libevwrapper.c and cmurmur.c are apparently still included here because they're explicitly called out in MANIFEST.in. This is actually desirable; we want those files included (at least in a source distribution) so that native libs can be recompiled if need be. The Cython C files should be regenerated in that case so they very definitely should not be in the source tarball. This looks very different from the source dist and wheel builds uploaded for 3.30.0: |
Contributor
Author
|
For sake of completeness I installed the wheel file built from this change in a local venv and confirmed that C source files are not present. Mainly wanted to make sure they weren't sneaking in from somewhere else. |
Contributor
Author
|
For sake of additional completeness I executed a normal wheel build using this branch and confirmed that the resulting wheels also don't have any extraneous C source files. This test indicates that our current wheel build infrastructure should play nice with this change and fix the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.