Open
Conversation
2 tasks
leborchuk
requested review from
Copilot and
tuhaihe
and removed request for
Copilot
Member
|
Will review it later. Thanks! |
Member
|
Hi, I've opened an issue regarding the container workflow: #1687. This appears to be a common limitation within the ASF, and I'll address it as soon as possible. |
tuhaihe
reviewed
Apr 21, 2026
tuhaihe
reviewed
Apr 22, 2026
There was a problem hiding this comment.
Pull request overview
Adds Rocky Linux 10 Docker build/test container definitions (based on Rocky9) and wires them into CI so images are built and validated.
Changes:
- Add Rocky10 build container (Dockerfile, configs, TestInfra tests, requirements).
- Add Rocky10 test container (Dockerfile and runtime init/configs).
- Update GitHub Actions workflows and RAT exclusions to include the Rocky10 paths.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
pom.xml |
Excludes Rocky10 test requirements file from RAT checks. |
devops/deploy/docker/test/rocky10/Dockerfile |
New Rocky10 “test environment” container image definition. |
devops/deploy/docker/test/rocky10/configs/init_system.sh |
Container init script for Rocky10 test environment (SSH, dirs, banner). |
devops/deploy/docker/test/rocky10/configs/gpinitsystem.conf |
gpinitsystem config for initializing a demo cluster in the test container. |
devops/deploy/docker/test/rocky10/configs/90-cbdb-limits |
Adds limits configuration for gpadmin in Rocky10 test container. |
devops/deploy/docker/build/rocky10/Dockerfile |
New Rocky10 “build environment” container image definition incl. xerces + Go install. |
devops/deploy/docker/build/rocky10/configs/init_system.sh |
Container init script for Rocky10 build environment (SSH, banner). |
devops/deploy/docker/build/rocky10/configs/gpinitsystem.conf |
gpinitsystem config included with Rocky10 build image. |
devops/deploy/docker/build/rocky10/configs/90-cbdb-limits |
Adds limits configuration for gpadmin in Rocky10 build container. |
devops/deploy/docker/build/rocky10/tests/testinfra/test_cloudberry_db_env.py |
TestInfra validation for Rocky10 build image packages and basic config. |
devops/deploy/docker/build/rocky10/tests/requirements.txt |
Python test dependencies list for Rocky10 build image tests. |
.github/workflows/docker-cbdb-test-containers.yml |
Adds rocky10 to matrix and path filters for test containers. |
.github/workflows/docker-cbdb-build-containers.yml |
Adds rocky10 to matrix and path filters for build containers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is the copy or Rocky9 containers. Changes comparing to Rocky9: - Get rid here of packages not available right now under Rocky10 repositories (for example rocky-release-hpc) - Move to the Java 21, it's default to Rocky Linux 10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This is the copy or Rocky9 containers.
What I've changed comparing to Rocky9:
Get rid here of packages not available right now under Rocky10 repositories (for example rocky-release-hpc)
Move to the Java 21, it's now default for Rocky linux 10