feat: add iceberg_data library alongside iceberg#631
Open
zhjwpku wants to merge 1 commit intoapache:mainfrom
Open
feat: add iceberg_data library alongside iceberg#631zhjwpku wants to merge 1 commit intoapache:mainfrom
zhjwpku wants to merge 1 commit intoapache:mainfrom
Conversation
Move data writers, deletes/, and puffin/ into a separate `iceberg_data`
library that links the existing `iceberg` target. `delete_file_index`
stays in `iceberg` because manifest_group embeds DeleteFileIndex::Builder
with only core dependencies.
* `iceberg` — unchanged target name for metadata/planning, expressions,
manifests, catalog (incl. in-memory), utilities, file I/O abstractions,
and delete_file_index.
* `iceberg_data` — data/, deletes/, puffin/; links `iceberg`.
`iceberg_bundle` links `iceberg_data` when the bundle is built.
`iceberg_rest` links `iceberg` and cpr only.
CMake: per-package `iceberg_install_cmake_package` installs
`iceberg-config.cmake`, `iceberg_data-config.cmake`, optional
`iceberg_bundle-config.cmake`, and matching `*-targets.cmake` under
`lib/cmake/<package>/`; install namespace remains `iceberg::`.
Split `find_dependency` lists so `iceberg` consumers do not pull
Arrow/Parquet/Avro/cpr. Vendored third-party exports are attached to the
package that owns them (core vs bundle vs rest). Add
`iceberg_rest-config.cmake.in` for the REST catalog package.
Meson and tests link the split targets; the example uses
`find_package(iceberg_bundle)` and `iceberg::iceberg_bundle_static`.
Symbol visibility: `iceberg_export.h` documents `ICEBERG_EXPORT` for the
main `iceberg` DLL; `iceberg_data_export.h` adds `ICEBERG_DATA_EXPORT` for
data-layer public APIs. Shared builds define `${UPPER_LIB_NAME}_EXPORTING`
(e.g. ICEBERG_DATA_EXPORTING) for MSVC. Types used across the boundary
(e.g. WriterProperties, Arrow guards) remain exported from `iceberg`.
| @@ -45,7 +45,7 @@ namespace iceberg { | |||
| /// \note This class is used to represent deletion vectors. The Puffin puffin | |||
| /// reader/write handle adding the additional required framing (length prefix, magic, | |||
Contributor
There was a problem hiding this comment.
reader/write reader/writer ?
| @@ -45,7 +45,7 @@ namespace iceberg { | |||
| /// \note This class is used to represent deletion vectors. The Puffin puffin | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move data writers, deletes/, and puffin/ into a separate
iceberg_datalibrary that links the existingicebergtarget.delete_file_indexstays inicebergbecause manifest_group embeds DeleteFileIndex::Builder with only core dependencies.iceberg— unchanged target name for metadata/planning, expressions, manifests, catalog (incl. in-memory), utilities, file I/O abstractions, and delete_file_index.iceberg_data— data/, deletes/, puffin/; linksiceberg.iceberg_bundlelinksiceberg_datawhen the bundle is built.iceberg_restlinksicebergand cpr only.CMake: per-package
iceberg_install_cmake_packageinstallsiceberg-config.cmake,iceberg_data-config.cmake, optionaliceberg_bundle-config.cmake, and matching*-targets.cmakeunderlib/cmake/<package>/; install namespace remainsiceberg::. Splitfind_dependencylists soicebergconsumers do not pull Arrow/Parquet/Avro/cpr. Vendored third-party exports are attached to the package that owns them (core vs bundle vs rest). Addiceberg_rest-config.cmake.infor the REST catalog package.Meson and tests link the split targets; the example uses
find_package(iceberg_bundle)andiceberg::iceberg_bundle_static.Symbol visibility:
iceberg_export.hdocumentsICEBERG_EXPORTfor the mainicebergDLL;iceberg_data_export.haddsICEBERG_DATA_EXPORTfor data-layer public APIs. Shared builds define${UPPER_LIB_NAME}_EXPORTING(e.g. ICEBERG_DATA_EXPORTING) for MSVC. Types used across the boundary (e.g. WriterProperties, Arrow guards) remain exported fromiceberg.