feat(memory-ingest+search): Phase 4C — synthesize-only consolidation for SUM#12
Draft
moralespanitz wants to merge 1 commit intoexperiment/phase2-combined-stackfrom
Draft
Conversation
Adds a synthesize-only consolidation path that re-uses the existing clustering and synthesis primitives (findConsolidationCandidates + synthesizeCluster) but does NOT call softDeleteMemory on cluster members. The LLM-synthesized summary is stored alongside the originals, tagged with metadata.fact_role: 'summary' and metadata.summary_of: [original_fact_ids]. Targets BEAM SUM (1/6 across 19 sprint-2 iters with EXP-08 archive- style consolidation; 2/6 without). EXP-08 actively hurt SUM because archiving cluster members removed the underlying facts SUM questions need to retrieve. Synthesizing alongside originals preserves those facts for TR / IE / etc. while still giving SUM-style queries a compact, retrievable answer. Trigger: per-user_id ingest turn counter (in-memory, not persisted). On every summarySynthesisTurnInterval ingested turn, the system clusters and synthesizes. Errors are logged and swallowed — ingest is never blocked. Retrieval awareness: a new search-pipeline stage (after current- state-ranking, before instruction-boost) multiplies summary results' score by summaryDownweightFactor (default 0.5) for non-SUM-style queries so summaries don't dilute regular retrieval. A small keyword detector (isSummarizationStyleQuery) skips the down-weight for queries like "summarize", "summary of", "what did we discuss", "give me an overview", "recap", "tl;dr". Defaults-off behind summarySynthesisEnabled. New config keys: - summarySynthesisEnabled: false - summarySynthesisTurnInterval: 30 - summaryDownweightFactor: 0.5 All three live in INTERNAL_POLICY_CONFIG_FIELDS (experimental tuning flags). summary_of is added to RESERVED_METADATA_KEYS. Existing consolidation primitives (findConsolidationCandidates and synthesizeCluster) are cleanly separable from the archive step in executeConsolidation — both are already exported and pure with respect to soft-deletion. No refactor of consolidation-service.ts was needed. Files changed: - src/services/summary-synthesis.ts (new, 136 LOC) - src/services/summary-downweight.ts (new, 79 LOC) - src/services/__tests__/summary-synthesis.test.ts (new, 305 LOC, 21 tests) - src/config.ts (+25) - src/services/search-pipeline.ts (+24) - src/services/memory-ingest.ts (+4 trigger calls + 1 import) - src/services/memory-service-types.ts (+4) - src/app/runtime-container.ts (+2) - src/db/repository-types.ts (+2) Tests (21 passed): flag-off no-op; triggers exactly twice across 60 turns at interval 30; "originals NOT soft-deleted" (the critical EXP-08-vs-EXP-SUM assertion); summary metadata shape; per-user counter independence; error swallowing; null synthesis skipped; non-positive interval guard; isSummarizationStyleQuery classifier table; down-weight reduces summary score below regular peer for non-SUM queries; down-weight skipped for "summarize" queries; no-op when factor >= 1; no-op when no summary results present. Typecheck: npx tsc --noEmit passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Periodic synthesis that builds summary memories alongside originals, never archiving. Targets BEAM SUM — currently 1/6 across N=3 with EXP-08 (scheduled-consolidation), 2/6 without it. EXP-08 actively hurt SUM because
executeConsolidationsoft-deletes cluster members; this PR keeps everything and tags summaries instead.Why this differs from EXP-08
EXP-08 (PR #10) calls
executeConsolidationwhich callssoftDeleteMemoryon cluster members — removes facts BEAM SUM/IE/TR questions need. This PR uses the lower-level primitives (findConsolidationCandidates,synthesizeCluster) directly and skips the archive step entirely. Originals are preserved.Three behavioral changes
current % summarySynthesisTurnInterval === 0, synthesize.metadata.fact_role: 'summary'andmetadata.summary_of: [original_fact_ids].applySummaryDownweightreduces summary scores bysummaryDownweightFactor(default 0.5) UNLESS query is summarization-style ("summarize", "give me an overview", etc.) — keeps summaries from diluting non-SUM retrieval.Scope (581 insertions, 9 files)
src/services/summary-synthesis.ts(new, 136 LOC)src/services/summary-downweight.ts(new, 79 LOC) — also includesisSummarizationStyleQuerykeyword detectorsrc/services/__tests__/summary-synthesis.test.ts(new, 305 LOC, 21 tests passing)src/config.ts(+25): three new flags + env loaders + allowlistsrc/services/search-pipeline.ts(+24): wire down-weight stagesrc/services/memory-ingest.ts(+5): synthesis call sitesrc/services/memory-service-types.ts(+4): IngestRuntimeConfig fieldssrc/app/runtime-container.ts(+2): CoreRuntimeConfig fieldsrc/db/repository-types.ts(+2):'summary_of'in RESERVED_METADATA_KEYSCritical test assertion
"does NOT soft-delete cluster members (the whole point vs EXP-08)" — explicitly verifies
softDeleteMemoryis never called from this code path.New config keys (defaults-off)
Notes
config-singleton-audit.test.tsis on baseline709242f, NOT introduced by this PR (verified by stashing and re-running).Test plan