Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d57d15883
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| onRebaseBranch={() => { | ||
| const agents = isRemote ? REMOTE_AGENTS : agentState.providers; | ||
| const provider = getPreferredAgent(agents) ?? undefined; | ||
| commands | ||
| .rebaseBranch(branch.id, provider) | ||
| .catch((e) => notifyError('Rebase failed', e)); | ||
| }} | ||
| onSquashCommits={() => { | ||
| const agents = isRemote ? REMOTE_AGENTS : agentState.providers; | ||
| const provider = getPreferredAgent(agents) ?? undefined; | ||
| commands | ||
| .squashCommits(branch.id, provider) | ||
| .catch((e) => notifyError('Squash failed', e)); |
There was a problem hiding this comment.
This change bypasses sessionMgr.startOrQueueSession(...) and calls commands.rebaseBranch/commands.squashCommits directly, which removes the branch-level queueing behavior those actions previously had. When a branch already has a running session, these actions can now start immediately and run concurrent Git operations in the same worktree (instead of being queued), which can cause command failures or conflicting state. Please route these actions through the existing queue path (or add equivalent backend gating) so they do not run in parallel with active branch sessions.
Useful? React with 👍 / 👎.
| if let Err(e) = start_session( | ||
| ai_config, | ||
| store_for_status.clone(), | ||
| app_handle.clone(), | ||
| registry, |
There was a problem hiding this comment.
If start_session(...) fails after a pipeline handoff, this path only emits an error event but never transitions the DB row out of running or deregisters the cancel token. In that scenario (e.g., provider unavailable/invalid at handoff time), the frontend may clear UI state from the event, but persisted session state remains incorrectly running and can get stuck until later recovery. This error branch should perform the same terminal-state transition/cleanup as other failure paths.
Useful? React with 👍 / 👎.
Add pipeline-backed branch commands, persisted pipeline state, terminal output normalization, and session UI for deterministic pre-AI handoff steps.
matt2e
force-pushed
the
commands-lead-to-session
branch
from
7416bfc to
5d125c1
Compare
1 participant
Summary
Tests