Fixing typos in events and encoding issues in localization#245
Open
Daevinius wants to merge 4 commits intock2plus:mainfrom
Open
Fixing typos in events and encoding issues in localization#245Daevinius wants to merge 4 commits intock2plus:mainfrom
Daevinius wants to merge 4 commits intock2plus:mainfrom
Conversation
EVTOPTD100511 — typo in localization assignment for tooltip EVTOPTB3110 — vanilla bug, clearly implies: if you have a stress trait = -health, if not — chance to gain stress EVTOPTA_WoL_7000 — typo in assignment of the second localization for an option
base_mongol_events.txt - character corruption during re-encoding 00_landed_titles.csv - b_haltålen redundant, keys changed to avoid diacritics in them 00_provinces.csv - redundant localization in Polish that is not even Polish 00_religions.csv - missing delimiter for Spanish localization 10_hl_silk_route_events.csv - typo in English localization
Events 3140-3144 follow the same pattern, only the attribute theme changes. However, event 3144, contrary to its 'learning' attribute theme, raises the 'martial' attribute value without mentioning it, so it's likely a vanilla bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.