Conversation
ono-max
commented
Apr 22, 2026
Comment on lines
+629
to
+633
| if len(subset_result.rest) == 0: | ||
| warn_and_exit_if_fail_fast_mode("Error: no tests found matching the path.") | ||
| return | ||
| else: | ||
| click.echo(click.style("No tests were selected for this code change.", fg="yellow"), err=True) |
Contributor
Author
There was a problem hiding this comment.
What do you think about this change?
Contributor
There was a problem hiding this comment.
If this kind of use case exists, it can’t really be helped, can it?
That said, I don’t think this would come up in normal scenarios. If we want to be safer, we could limit it to cases where the adaptive dynamic subset is enabled.
Alternatively, we could add a comment noting that this issue may occur when using the adaptive dynamic subset.
Contributor
Author
There was a problem hiding this comment.
Thanks. Updated based on your suggestion: e499c91
Konboi
approved these changes
Apr 28, 2026
Contributor
Konboi
left a comment
Konboi
left a comment
There was a problem hiding this comment.
I left a comment however not to block your progress, I'll approve this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adaptive Dynamic Subset can return an empty subset when the model decides no tests in that suite are relevant to the code change.
Until now, the CLI treated any empty
subsetas:Error: no tests found matching the path.That's confusing for users even though that empty subset is valid. I got this feedback from users, so I'd like to fix this problem.