refactor(lease): centralized LeaseManager decouples heartbeats#401
Merged
refactor(lease): centralized LeaseManager decouples heartbeats#401
Conversation
…oll loop Replace inline heartbeat logic in both TaskRunner and AsyncTaskRunner with a process-wide LeaseManager singleton. A background daemon thread checks for due heartbeats at ~1s intervals and dispatches them to a ThreadPoolExecutor(4), so heartbeat API calls and retries never block task polling. Key changes: - LeaseManager: singleton with background thread + thread pool, fork-safe via PID check, lazy start on first track() call - TaskRunner: delegates to LeaseManager.track/untrack instead of inline _send_due_heartbeats/_send_heartbeat methods - AsyncTaskRunner: same delegation; creates a sync TaskResourceApi for LeaseManager since heartbeats run in the thread pool, not the event loop - task_handler.py: clean — no LeaseManager knowledge needed - 21 unit tests covering track/untrack, heartbeat dispatch, retries, non-blocking behavior, singleton/fork safety, thread safety Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
v1r3n
changed the title
Codecov Report❌ Patch coverage is
... and 56 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Three tests against a live Conductor server: 1. Async task with heartbeat → COMPLETED (50s sleep, 10s timeout) 2. Async task without heartbeat → TIMED_OUT 3. Performance: heartbeat tracking adds 0ms overhead on fast tasks
bradyyie
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace inline heartbeat logic in both TaskRunner and AsyncTaskRunner with a process-wide LeaseManager singleton. A background daemon thread checks for due heartbeats at ~1s intervals and dispatches them to a ThreadPoolExecutor(4), so heartbeat API calls and retries never block task polling.
Key changes: