Conversation
shoom3301
commented
Apr 30, 2026
| async getPushNotifications() { | ||
| const push = true | ||
| const notificationsConsumer = await strapi.entityService.findOne(NOTIFICATIONS_CONSUMER_MODULE_ID, SINGLETON_ID, { | ||
| populate: ['id', 'lastConsumedNotificationDate'] |
Contributor
Author
There was a problem hiding this comment.
- id is always returned, no need to populate it.
- lastConsumedNotificationDate (if it’s a simple field like datetime) is also returned by default.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
limitofzero
requested changes
Apr 30, 2026
Contributor
limitofzero
left a comment
limitofzero
left a comment
There was a problem hiding this comment.
19.70 src/api/telegram-subscription/services/telegram-subscription.ts:69:7 - error TS2322: Type 'AnyEntity | AnyEntity[]' is not assignable to type '{ id: string; account: string; chatId: string; }[]'.
19.70 Type 'AnyEntity' is missing the following properties from type '{ id: string; account: string; chatId: string; }[]': length, pop, push, concat, and 29 more.
19.70
19.70 69 return strapi.entityService.findMany(
19.70 ~~~~~~
19.70
19.70 Found 8 error(s).
There is an issue in building docker image
Contributor
Author
|
Weird, it builds locally well |
limitofzero
approved these changes
Apr 30, 2026
kernelwhisperer
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded Strapi packages to the highest 4.x version and added changes to fit the new versions