fix: remove web middleware from github setup and exchange-code routes#2631
Open
kaylenmistry wants to merge 1 commit intodiggerhq:developfrom
Open
fix: remove web middleware from github setup and exchange-code routes#2631kaylenmistry wants to merge 1 commit intodiggerhq:developfrom
kaylenmistry wants to merge 1 commit intodiggerhq:developfrom
Conversation
These endpoints are proxied through the UI, which handles authentication before forwarding the request. The backend web middleware expects a session cookie that is not present in proxied requests, causing a 403. This aligns setup and exchange-code with callback, which was already registered outside the auth group for the same reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLAIMER: I consulted Claude Opus to understand the codebase and come up with a solution based on the issue described below.
These endpoints are proxied through the UI, which handles authentication before forwarding the request. The backend web middleware expects a session cookie that is not present in proxied requests, causing a 403 on
/orchestrator/github/setup.This aligns
/github/setupand/github/exchange-codewith/github/callback, which was already registered outside the auth group for the same reason.