docs: clarify --add-host example uses two terminals#6956
Open
WilliamK112 wants to merge 1 commit intodocker:masterfrom
Open
docs: clarify --add-host example uses two terminals#6956WilliamK112 wants to merge 1 commit intodocker:masterfrom
WilliamK112 wants to merge 1 commit intodocker:masterfrom
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
Author
|
Thanks! I took this PR in the direction of the earlier two-shell suggestion from #5558 to keep the example simple and make it explicit that the HTTP server needs to keep running while the container connects to it. I did not switch it to an If you would prefer the docs to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5558.
Summary
Validation
git diff --check