Avoid redundant array alloc when TryReadSqlValueInternal for SQLVECTOR#4156
Merged
paulmedynski merged 2 commits intodotnet:mainfrom Apr 28, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unnecessary byte[] allocation when reading binary/vector TDS values in TryReadSqlValueInternal, relying on TryReadByteArrayWithContinue to allocate (or reuse snapshot storage) as needed.
Changes:
- Eliminates a redundant
new byte[length]prior to callingTryReadByteArrayWithContinue(...). - Uses inline
out byte[] bdeclaration to keep allocation responsibility insideTryReadByteArrayWithContinue.
paulmedynski
approved these changes
Apr 10, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
👍🏼 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4156 +/- ##
==========================================
- Coverage 66.02% 64.30% -1.73%
==========================================
Files 277 272 -5
Lines 42989 65783 +22794
==========================================
+ Hits 28383 42301 +13918
- Misses 14606 23482 +8876
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheenamalhotra
approved these changes
Apr 24, 2026
Contributor
|
@SimonCropp - The macOS failures are pretty weird. Can you rebase/merge from main? Lots of new build-related work there. |
…ay-alloc-when-TryReadSqlValueInternal-for-SQLVECTOR
Contributor
Author
|
@paulmedynski done |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.