Consistently return path as binary in relative_to_cwd#15316
Open
lukaszsamson wants to merge 2 commits intoelixir-lang:mainfrom
Open
Consistently return path as binary in relative_to_cwd#15316lukaszsamson wants to merge 2 commits intoelixir-lang:mainfrom
lukaszsamson wants to merge 2 commits intoelixir-lang:mainfrom
Conversation
Previously if path parameter was passed in as chardata it was returned as is on `:file.get_cwd` failure All `relative_to` and `join` code paths normalize to binary
sabiwara
approved these changes
Apr 28, 2026
Contributor
sabiwara
left a comment
sabiwara
left a comment
There was a problem hiding this comment.
Thank you @lukaszsamson 💜
Maybe we could have a test case for this?
Contributor
Author
Done, I added unix only test for that scenario |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if path parameter was passed in as chardata it was returned as is on
:file.get_cwdfailure Allrelative_toandjoincode paths normalize to binary